You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/08/05 12:45:27 UTC

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

GitHub user jinossy opened a pull request:

    https://github.com/apache/tajo/pull/678

    TAJO-1743: Improve calculation of intermediate table statistics

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinossy/tajo TAJO-1743

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #678
    
----
commit 0d1a62cb7800a82b8bfc72d72b6a9954e371acfa
Author: Jinho Kim <jh...@apache.org>
Date:   2015-08-05T10:44:13Z

    TAJO-1743: Improve calculation of intermediate table statistics

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/678#issuecomment-129296719
  
    +1
    
    LGTM. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/678


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/678#discussion_r36596307
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java ---
    @@ -56,14 +57,19 @@
       private KeyProjector keyProjector;
     
       public RangeShuffleFileWriteExec(final TaskAttemptContext context,
    -                                   final PhysicalExec child, final Schema inSchema, final Schema outSchema,
    -                                   final SortSpec[] sortSpecs) throws IOException {
    -    super(context, inSchema, outSchema, child);
    +                                   final ShuffleFileWriteNode plan,
    --- End diff --
    
    Could you explain why you remove output schema from parameters of the constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/678#issuecomment-129269536
  
    Thanks @jinossy 
    
    I found following codes using your comments:
    ``` 
    return new RangeShuffleFileWriteExec(ctx, subOp, plan.getInSchema(), plan.getInSchema(), sortSpecs); 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1743: Improve calculation of intermediate ...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/678#issuecomment-129268173
  
    You can find it in PhysicalPlannerImpl. in-out schema is same in RangeShuffleWriter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---