You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/26 09:41:37 UTC

[GitHub] [pulsar] casuallc opened a new pull request #12990: Fix unable to subscribe non-persistent topics via regex.

casuallc opened a new pull request #12990:
URL: https://github.com/apache/pulsar/pull/12990


   ### Motivation
   
   #12328 
   
   ### Modifications
   
   
   ### Verifying this change
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #12990: Fix unable to subscribe non-persistent topics via regex.

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #12990:
URL: https://github.com/apache/pulsar/pull/12990#issuecomment-979976227


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on a change in pull request #12990: Fix unable to subscribe non-persistent topics via regex.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #12990:
URL: https://github.com/apache/pulsar/pull/12990#discussion_r757736235



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
##########
@@ -1167,8 +1167,7 @@ public ServiceUnitId getServiceUnitId(TopicName topicName) throws Exception {
                                 pulsar.getBrokerService().getMultiLayerTopicMap().get(namespaceName.toString())
                                         .forEach((__, bundle) -> {
                                             bundle.forEach((topicName, topic) -> {
-                                                if (topic instanceof NonPersistentTopic
-                                                        && ((NonPersistentTopic) topic).isActive()) {

Review comment:
       Have you checked why do we added `isActive` check in the first place?
   Will it affect other use cases if we remove this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #12990: Fix unable to subscribe non-persistent topics via regex.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12990:
URL: https://github.com/apache/pulsar/pull/12990#issuecomment-1051440882


   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org