You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/06/30 14:44:22 UTC
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/29
More windows compatibility changes
Fix paths for private keys;
Documentation;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn windows-compatibility-20140630
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit c4cfeada4352da951ad31e08336b1490f97a3c1d
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-06-30T12:40:40Z
OS-independent path for default private key locations
commit 14eaf7822888c3509aeb00c54a196ef759e5c467
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-06-30T12:41:04Z
Tips for using the JSGui launcher on Windows.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/29#discussion_r14375503
--- Diff: core/src/main/java/brooklyn/location/basic/LocationConfigKeys.java ---
@@ -36,7 +38,8 @@
public static final ConfigKey<String> PASSWORD = ConfigKeys.newStringConfigKey("password");
public static final ConfigKey<String> PUBLIC_KEY_FILE = ConfigKeys.newStringConfigKey("publicKeyFile", "colon-separated list of ssh public key file(s) to use; if blank will infer from privateKeyFile by appending \".pub\"");
public static final ConfigKey<String> PUBLIC_KEY_DATA = ConfigKeys.newStringConfigKey("publicKeyData", "ssh public key string to use (takes precedence over publicKeyFile)");
- public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile", "colon-separated list of ssh private key files; uses first in list that can be read", "~/.ssh/id_rsa:~/.ssh/id_dsa");
+ public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile", "colon-separated list of ssh private key files; uses first in list that can be read",
--- End diff --
The description says colon-separated, but on windows it is ";" separated for the default value.
Where is this value used, to split apart the two paths? I just had a very quick look and couldn't find it. Does that code need updated as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/29#issuecomment-47641348
updated javadoc and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/29#discussion_r14397244
--- Diff: utils/common/src/main/java/brooklyn/util/os/Os.java ---
@@ -181,7 +181,7 @@ public static String mergePathsUnix(String ...items) {
/** merges paths using the local file separator */
--- End diff --
update javadoc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More windows compatibility change...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/29#discussion_r14391364
--- Diff: core/src/main/java/brooklyn/location/basic/LocationConfigKeys.java ---
@@ -36,7 +38,8 @@
public static final ConfigKey<String> PASSWORD = ConfigKeys.newStringConfigKey("password");
public static final ConfigKey<String> PUBLIC_KEY_FILE = ConfigKeys.newStringConfigKey("publicKeyFile", "colon-separated list of ssh public key file(s) to use; if blank will infer from privateKeyFile by appending \".pub\"");
public static final ConfigKey<String> PUBLIC_KEY_DATA = ConfigKeys.newStringConfigKey("publicKeyData", "ssh public key string to use (takes precedence over publicKeyFile)");
- public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile", "colon-separated list of ssh private key files; uses first in list that can be read", "~/.ssh/id_rsa:~/.ssh/id_dsa");
+ public static final ConfigKey<String> PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("privateKeyFile", "colon-separated list of ssh private key files; uses first in list that can be read",
--- End diff --
Will update the comment.
Used in brooklyn.location.basic.LocationConfigUtils.{getKeyData, getPublicKeyData}, lines 44, 70.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---