You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2023/04/05 07:10:36 UTC
[GitHub] [camel] dk2k opened a new pull request, #9816: Removed empty List headerParts and the related loop
dk2k opened a new pull request, #9816:
URL: https://github.com/apache/camel/pull/9816
Removed empty List headerParts and the related loop. This loop does nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9816: Removed empty List headerParts and the related loop
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9816:
URL: https://github.com/apache/camel/pull/9816#issuecomment-1497022973
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] dk2k commented on a diff in pull request #9816: Removed empty List headerParts and the related loop
Posted by "dk2k (via GitHub)" <gi...@apache.org>.
dk2k commented on code in PR #9816:
URL: https://github.com/apache/camel/pull/9816#discussion_r1158145625
##########
components/camel-soap/src/main/java/org/apache/camel/dataformat/soap/SoapDataFormat.java:
##########
@@ -121,33 +121,18 @@ protected List<Object> createContentFromObject(
final Object inputObject, String soapAction,
List<Object> headerElements) {
List<Object> bodyParts = new ArrayList<>();
- List<Object> headerParts = new ArrayList<>();
bodyParts.add(inputObject);
List<Object> bodyElements = new ArrayList<>();
for (Object bodyObj : bodyParts) {
QName name = elementNameStrategy.findQNameForSoapActionOrType(soapAction, bodyObj.getClass());
if (name == null) {
LOG.warn("Could not find QName for class {}", bodyObj.getClass().getName());
- continue;
} else {
bodyElements.add(getElement(bodyObj, name));
}
}
- for (Object headerObj : headerParts) {
- QName name = elementNameStrategy.findQNameForSoapActionOrType(soapAction, headerObj.getClass());
- if (name == null) {
- LOG.warn("Could not find QName for class {}", headerObj.getClass().getName());
- continue;
- } else {
- JAXBElement<?> headerElem = getElement(headerObj, name);
- if (null != headerElem) {
- headerElements.add(headerElem);
Review Comment:
headerParts is always an empty list. You refer to the code inside the loop, but this loop iterates through an empty list. Hence, the referred code is never reached. The entire loop can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9816: Removed empty List headerParts and the related loop
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9816:
URL: https://github.com/apache/camel/pull/9816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #9816: Removed empty List headerParts and the related loop
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #9816:
URL: https://github.com/apache/camel/pull/9816#discussion_r1158130194
##########
components/camel-soap/src/main/java/org/apache/camel/dataformat/soap/SoapDataFormat.java:
##########
@@ -121,33 +121,18 @@ protected List<Object> createContentFromObject(
final Object inputObject, String soapAction,
List<Object> headerElements) {
List<Object> bodyParts = new ArrayList<>();
- List<Object> headerParts = new ArrayList<>();
bodyParts.add(inputObject);
List<Object> bodyElements = new ArrayList<>();
for (Object bodyObj : bodyParts) {
QName name = elementNameStrategy.findQNameForSoapActionOrType(soapAction, bodyObj.getClass());
if (name == null) {
LOG.warn("Could not find QName for class {}", bodyObj.getClass().getName());
- continue;
} else {
bodyElements.add(getElement(bodyObj, name));
}
}
- for (Object headerObj : headerParts) {
- QName name = elementNameStrategy.findQNameForSoapActionOrType(soapAction, headerObj.getClass());
- if (name == null) {
- LOG.warn("Could not find QName for class {}", headerObj.getClass().getName());
- continue;
- } else {
- JAXBElement<?> headerElem = getElement(headerObj, name);
- if (null != headerElem) {
- headerElements.add(headerElem);
Review Comment:
Headers is added to the incoming headerElements parameter in the method, so the old code looks correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org