[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9469: [mypy] Enforcing typing for superset.examples

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9469: [mypy] Enforcing typing for superset.examples
URL: https://github.com/apache/incubator-superset/pull/9469#discussion_r403576044
 
 

 ##########
 File path: superset/examples/countries.py
 ##########
 @@ -2498,13 +2498,8 @@
         all_lookups[lookup][country[lookup].lower()] = country
 
 
-def get(field, symbol):
+def get(field: str, symbol: str) -> Optional[Dict[str, Any]]:
     """
     Get country data based on a standard code and a symbol
-
 
 Review comment:
   These examples were clearly wrong given the return type and thus I removed them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org