You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 04:32:31 UTC

[GitHub] [pulsar] liangyepianzhou commented on pull request #17853: [fix][doc] Rewrite the steps of docker-deploy

liangyepianzhou commented on PR #17853:
URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1274073381

   @Anonymitaet Thanks for the reminder again.
   Here is a very interesting point. 
   When you told me last time that you needed to attach a screenshot of the preview, I understood the preview from the perspective of a technician, so I attached a screenshot of the successful deployment of the cluster.
   But in fact, you meant to attach a preview screenshot of the document/website.
   I think this question may also confuse other newcomers.
   To solve this problem, I have a small suggestion about the description template.
   
   ```
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   
   Document in the google doc: <! -- ENTER URL HERE --> 
   <! If your PR contains a lot of doc changes -->
   
   Website local preview <! ATTACH PREVIEW SCREENSHOTS>
   <! If your PR contains doc changes, you need to run `sh start.sh` at `$pwd`/site2/website and attach the preview screenshots at here. -->
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org