[jira] [Commented] (OAK-8185) Improve CompositeNodeStore performance

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806524#comment-16806524 ] 

Michael Dürig commented on OAK-8185:
------------------------------------

{quote}should switch to the non-composite implementation
{quote}
This remotely rings a bell with me but I'm not able to put my finger on it. However, you need to be careful here to also switch back to the composite implementation when traversing up again.

> Improve CompositeNodeStore performance
> --------------------------------------
>
>                 Key: OAK-8185
>                 URL: https://issues.apache.org/jira/browse/OAK-8185
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: store-composite
>            Reporter: Marcel Reutegger
>            Priority: Minor
>
> While working on OAK-8141 I noticed the benchmark numbers for GetDeepNodeTest on Oak-Store-Composite are rather low compared to Oak-Segment-Tar.
> {noformat}
> Apache Jackrabbit Oak 1.12-SNAPSHOT
> # GetDeepNodeTest                  C     min     10%     50%     90%     max       N 
> Oak-Segment-Tar                    1      35      37      39      41      64    1524
> Oak-Composite-Store                1     203     204     208     214     236     288
> {noformat}
> In an offline conversion [~tomek.rekawek] mentioned the overhead shouldn't be that big because the implementation should switch to the non-composite implementation as soon as the read operation traverses into the global/writable node store. It seems however, this is not the case  when running GetDeepNodeTest. So, this may well be a bug and not an improvement, as filed at the moment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)