You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/23 16:49:51 UTC
[GitHub] [hive] jsoref opened a new pull request #2810: HIVE-24390 Spelling common
jsoref opened a new pull request #2810:
URL: https://github.com/apache/hive/pull/2810
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling) in the `common` directory (and a file named `common`).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Typos lead to all sorts of problems, branding errors, tests that don't test what's expected, difficulty in understanding both the code and the product.
Landing this would make it possible to extend the check-spelling workflow for the `common/` directory (while guarding against additional typos in them once a directory's typos have been fixed). See https://github.com/apache/hive/pull/1674#issuecomment-973098911
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Probably the changes in `common/src/java/org/apache/hadoop/hive/conf/HiveConf.java`
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
The CI does testing (negative testing: https://github.com/jsoref/hive/commit/801665d4d7bc2b110bb79c8cb67f1124b0169e53#commitcomment-60756038; positive testing w/ this PR: https://github.com/jsoref/hive/commit/c1bd0cdc28733c2e97f163d9f8bb92154a34180c) and the goal is to include it.
Depending on the order of things, this PR could be landed w/ the CI extension as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2810: HIVE-24390 Spelling common
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2810:
URL: https://github.com/apache/hive/pull/2810#issuecomment-987671319
it seems like there were some unrelated failures? I've restarted the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #2810: HIVE-24390 Spelling common
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #2810:
URL: https://github.com/apache/hive/pull/2810#discussion_r763734518
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -5106,25 +5106,25 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
"Specifies the minimum amount of tasks, executed by a particular LLAP daemon, before the health\n" +
"status of the node is examined."),
LLAP_NODEHEALTHCHECKS_MININTERVALDURATION(
- "hive.llap.nodehealthckecks.minintervalduration", "300s",
+ "hive.llap.nodehealthchecks.minintervalduration", "300s",
Review comment:
actually; this is a breaking change - but I don't think anyone have *ever* changed these configs....so lets keep them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2810: HIVE-24390 Spelling common
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2810:
URL: https://github.com/apache/hive/pull/2810#issuecomment-989668675
I've kicked off the tests once more - but the test failures seem to be releated to the changes; because the same set of tests failed.
http://ci.hive.apache.org/job/hive-precommit/job/PR-2810/2/testReport/org.apache.hadoop.hive.cli/TestNegativeLlapLocalCliDriver/Testing___split_11___PostProcess___testCliDriver_stats_publisher_error_1_/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #2810: HIVE-24390 Spelling common
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #2810:
URL: https://github.com/apache/hive/pull/2810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org