[GitHub] [arrow] lidavidm commented on a change in pull request #10585: ARROW-12016 [C++] Implement array_sort_indices and sort_indices for BOOL type

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #10585:
URL: https://github.com/apache/arrow/pull/10585#discussion_r671329597



##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -477,6 +491,87 @@ class ArrayCountSorter {
   }
 };
 
+using ::arrow::internal::Bitmap;
+
+template <>
+class ArrayCountSorter<BooleanType> {
+ public:
+  ArrayCountSorter() = default;
+
+  // Returns where null starts.
+  uint64_t* Sort(uint64_t* indices_begin, uint64_t* indices_end,
+                 const BooleanArray& values, int64_t offset,
+                 const ArraySortOptions& options) {
+    // 32bit counter performs much better than 64bit one

Review comment:
       Unless it's benchmarked here as well, maybe let's remove the comment to avoid being confusing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org