[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #456: feat: allow override of default apisix resource labels

["tokers (via GitHub)" <gi...@apache.org>]

tokers commented on code in PR #456:
URL: https://github.com/apache/apisix-helm-chart/pull/456#discussion_r1092660992


##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -23,6 +23,12 @@ nameOverride: ""
 
 fullnameOverride: ""
 
+# -- Override default labels assigned to Apache APISIX dashboard resource
+labelsOverride: {}
+# labelsOverride:
+#   app.kubernetes.io/name: "{{ .Release.Name }}"
+#   app.kubernetes.io/instance: '{{ include "apisix-dashboard.name" . }}'

Review Comment:
   ```suggestion
   #   app.kubernetes.io/instance: '{{ include "apisix-ingress-controller.name" . }}'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org