You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/09/06 00:13:35 UTC
Review Request 25403: Override entrypoint when shell enabled in Docker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description
-------
Override entrypoint when shell enabled in Docker
Diffs
-----
src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review52543
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25403]
All tests passed.
- Mesos ReviewBot
On Sept. 5, 2014, 10:13 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Override entrypoint when shell enabled in Docker
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review53014
-----------------------------------------------------------
Bad patch!
Reviews applied: [25403]
Failed command: ./bootstrap
Error:
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
autom4te: cannot open > /tmp/arJNBSoQ/am4tIzfWTq/traces.m4: No such file or directory
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --warnings=all
autom4te: cannot create /tmp/arJNBSoQ/am4t5299.31971: No such file or directory
at /usr/bin/autom4te line 969.
autoreconf: /usr/bin/autoconf failed with exit status: 2
- Mesos ReviewBot
On Sept. 11, 2014, 12:40 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/25403
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review53533
-----------------------------------------------------------
Ship it!
But I re-opened the '-c' issue so that you can add a comment above argv.push_back("-c") so that it's clear. Thanks Tim!
- Benjamin Hindman
On Sept. 11, 2014, 12:40 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/25403
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review53682
-----------------------------------------------------------
Just rebased on master
- Timothy Chen
On Sept. 17, 2014, 3:48 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/25403
>
>
> Diffs
> -----
>
> src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/25403
Diffs (updated)
-----
src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review53637
-----------------------------------------------------------
Patch looks great!
Reviews applied: [25403]
All tests passed.
- Mesos ReviewBot
On Sept. 16, 2014, 10:37 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2014, 10:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/25403
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
(Updated Sept. 16, 2014, 10:37 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/25403
Diffs (updated)
-----
src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 12:40 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/25403
Diffs
-----
src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 12:40 a.m.)
Review request for drill, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/25403
Diffs (updated)
-----
src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 9, 2014, 6:50 p.m., Benjamin Hindman wrote:
> > src/docker/docker.cpp, line 337
> > <https://reviews.apache.org/r/25403/diff/1/?file=680701#file680701line337>
> >
> > Why not move this up above as well?
>
> Timothy Chen wrote:
> The Docker cli --entrypoint only allows you to put in a single string, but we actually need a array of entrypoint entries (which is what docker inspect returns).
> I tried --entrypoint="/bin/sh -c" on the cli and it immediately failed. Therefore, I have to run this in the cli: docker run --entrypoint=/bin/sh busybox -c ls
Ah, I see, honestly this isn't obvious from the code and it's nasty that it's linked but not well scoped (so copy/paste errors are likely) so explaining why you're adding the '-c' there when you add it would probably save someone a headache in the future!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review52767
-----------------------------------------------------------
On Sept. 11, 2014, 12:40 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/25403
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
> On Sept. 9, 2014, 6:50 p.m., Benjamin Hindman wrote:
> > src/docker/docker.cpp, line 337
> > <https://reviews.apache.org/r/25403/diff/1/?file=680701#file680701line337>
> >
> > Why not move this up above as well?
The Docker cli --entrypoint only allows you to put in a single string, but we actually need a array of entrypoint entries (which is what docker inspect returns).
I tried --entrypoint="/bin/sh -c" on the cli and it immediately failed. Therefore, I have to run this in the cli: docker run --entrypoint=/bin/sh busybox -c ls
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review52767
-----------------------------------------------------------
On Sept. 5, 2014, 10:13 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Override entrypoint when shell enabled in Docker
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review52767
-----------------------------------------------------------
src/docker/docker.cpp
<https://reviews.apache.org/r/25403/#comment91838>
For posterity it would be great to leave a comment explaining why you always want to use --entrypoint (i.e., why our initial implementation was insufficient). ;-) A small comment and a link to the JIRA should be sufficient!
src/docker/docker.cpp
<https://reviews.apache.org/r/25403/#comment91836>
Why not move this up above as well?
- Benjamin Hindman
On Sept. 5, 2014, 10:13 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Override entrypoint when shell enabled in Docker
>
>
> Diffs
> -----
>
> src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
>
> Diff: https://reviews.apache.org/r/25403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25403: Override entrypoint when shell enabled in
Docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 12:40 a.m.)
Review request for drill, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/25403
Diffs (updated)
-----
src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e
Diff: https://reviews.apache.org/r/25403/diff/
Testing
-------
make check
Thanks,
Timothy Chen