[GitHub] [pinot] mcvsubbu commented on a change in pull request #7547: Cleanup sys out

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #7547:
URL: https://github.com/apache/pinot/pull/7547#discussion_r725271914



##########
File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/reader/FixedByteWidthRowColDataFileReaderTest.java
##########
@@ -87,7 +86,6 @@ void testMultiCol()
     dos.flush();
     dos.close();
     RandomAccessFile raf = new RandomAccessFile(f, "rw");
-//    System.out.println("file size: " + raf.getChannel().size());

Review comment:
       presumably this (and some of the other perhaps) is to be able to debug the test if there is an intermittent failure introduced due to randomness. If you can move the sys.out to print out the seed of the Random object created, then we are good. If the test ever fails, we can manually re-seed the Random object and run it to reproduce the failure.
   If it is never printed out, we will have a hard time debugging the random failures, so it is needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org