You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/04 22:28:09 UTC

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9634: [WIP][TVMScript] Syntax sugar for reads & writes

junrushao1994 commented on a change in pull request #9634:
URL: https://github.com/apache/tvm/pull/9634#discussion_r762472910



##########
File path: python/tvm/script/tir/__init__.pyi
##########
@@ -211,8 +211,12 @@ def alloc_buffer(
 special_stmt - Reads/Writes
 """
 
-def reads(read_regions: Union[BufferSlice, List[BufferSlice]]) -> None: ...
-def writes(write_region: Union[BufferSlice, List[BufferSlice]]) -> None: ...
+def reads(
+    read_regions: Union[BufferSlice, List[BufferSlice]], *other_regions: BufferSlice
+) -> None: ...
+def writes(
+    write_region: Union[BufferSlice, List[BufferSlice]], *other_regions: BufferSlice
+) -> None: ...

Review comment:
       Just curious, is it possible to use @overload to separate the logic more clearly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org