[jira] Commented: (MAPREDUCE-1143) runningMapTasks counter is not properly decremented in case of failed Tasks.

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784077#action_12784077 ] 

Hemanth Yamijala commented on MAPREDUCE-1143:
---------------------------------------------

After a discussion with Arun, I felt I might clarify little more on what I am proposing. Some details:

- In TaskInProgress.java, introduce:
{code}
  boolean isRunning(TaskAttemptID taskId) {
    return activeTasks.containsKey(taskId);
  }
{code}

- Modify JobInProgress.failedTask private API to have an additional parameter wasAttemptRunning, which would be initialized in JIP.updateTaskStatus to tip.isRunning(status.getTaskID())

- Use wasAttemptRunning only to update the running* counters

I originally thought we can modify wasRunning to indicate if the attempt was running (rather than if the TIP was running). But after speaking with Arun, I feel we want to localize the changes to as much as possible.

> runningMapTasks counter is not properly decremented in case of failed Tasks.
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1143
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1143
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: rahul k singh
>            Priority: Blocker
>         Attachments: MAPRED-1143-1.patch, MAPRED-1143-2.patch, MAPRED-1143-2.patch, MAPRED-1143-3.patch, MAPRED-1143-4.patch, MAPRED-1143-ydist-1.patch, MAPRED-1143-ydist-2.patch, MAPRED-1143-ydist-3.patch, MAPRED-1143-ydist-4.patch, MAPRED-1143-ydist-5.patch, MAPRED-1143-ydist-6.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.