You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Robert Scholte <rf...@apache.org> on 2016/01/25 20:51:34 UTC
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Hi,
I really wonder why it is useful to add a skip-parameter to the packaging
plugin? The goal for every Maven project is to end up with some (packaged)
artifact, right?
A skip-parameter because a lot of other plugins have it as well is IMHO
not a good reason, so what would be a valid usecase here?
thanks,
Robert
Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
<ji...@apache.org>:
>
> [
> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Karl Heinz Marbaise closed MWAR-350.
> ------------------------------------
> Resolution: Fixed
> Assignee: Karl Heinz Marbaise
>
> Fixed in [r1726671|http://svn.apache.org/r1726671]
>
>> Add Skip Parameter to Skip the process
>> --------------------------------------
>>
>> Key: MWAR-350
>> URL: https://issues.apache.org/jira/browse/MWAR-350
>> Project: Maven WAR Plugin
>> Issue Type: New Feature
>> Affects Versions: 2.6
>> Environment: Maven 3.3.3
>> maven-war-plugin 2.6
>> Reporter: Keshan De Silva
>> Assignee: Karl Heinz Marbaise
>> Priority: Trivial
>> Fix For: 3.0.0
>>
>> Attachments: Maven_War_Skip.patch
>>
>>
>> * It will be usefull if maven-war plugin has a skip configuration as in
>> most of the plugins have.
>> {code:xml}
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-war-plugin</artifactId>
>> <version>2.6</version>
>> <configuration>
>> <skip>true</skip>
>> </configuration>
>> {code}
>> (I have attached a patch file)
>>
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Robert Scholte <rf...@apache.org>.
Op Mon, 25 Jan 2016 20:54:20 +0100 schreef Aldrin Leal
<al...@leal.eng.br>:
> There are cases where one could use a profile to build a custom assembly
> of
> the war (say, like with jetty runner to run under a given paas), and
> attaching just the relevant classes / assets, thus saving time.
Custom assembly profile, that sounds like abuse of profiles.
Be aware that we've decided some behavior of both the install and deploy
plugins, see MavenProject with only attachments must have packaging "pom"
[1][2].
It looks like here's an example which used to rely on that behavior.
Is the effect the same as 'mvn compile jetty:run'?
thanks,
Robert
[1] https://issues.apache.org/jira/browse/MINSTALL-118
[2] https://issues.apache.org/jira/browse/MDEPLOY-205
>
>
> --
> -- Aldrin Leal, <al...@leal.eng.br> / http://about.me/aldrinleal
>
> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
> wrote:
>
>> Hi,
>>
>> I really wonder why it is useful to add a skip-parameter to the
>> packaging
>> plugin? The goal for every Maven project is to end up with some
>> (packaged)
>> artifact, right?
>> A skip-parameter because a lot of other plugins have it as well is IMHO
>> not a good reason, so what would be a valid usecase here?
>>
>> thanks,
>> Robert
>>
>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA) <
>> jira@apache.org>:
>>
>>
>>> [
>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Karl Heinz Marbaise closed MWAR-350.
>>> ------------------------------------
>>> Resolution: Fixed
>>> Assignee: Karl Heinz Marbaise
>>>
>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>
>>> Add Skip Parameter to Skip the process
>>>> --------------------------------------
>>>>
>>>> Key: MWAR-350
>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>> Project: Maven WAR Plugin
>>>> Issue Type: New Feature
>>>> Affects Versions: 2.6
>>>> Environment: Maven 3.3.3
>>>> maven-war-plugin 2.6
>>>> Reporter: Keshan De Silva
>>>> Assignee: Karl Heinz Marbaise
>>>> Priority: Trivial
>>>> Fix For: 3.0.0
>>>>
>>>> Attachments: Maven_War_Skip.patch
>>>>
>>>>
>>>> * It will be usefull if maven-war plugin has a skip configuration as
>>>> in
>>>> most of the plugins have.
>>>> {code:xml}
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-war-plugin</artifactId>
>>>> <version>2.6</version>
>>>> <configuration>
>>>> <skip>true</skip>
>>>> </configuration>
>>>> {code}
>>>> (I have attached a patch file)
>>>>
>>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Aldrin Leal <al...@leal.eng.br>.
There are cases where one could use a profile to build a custom assembly of
the war (say, like with jetty runner to run under a given paas), and
attaching just the relevant classes / assets, thus saving time.
--
-- Aldrin Leal, <al...@leal.eng.br> / http://about.me/aldrinleal
On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
wrote:
> Hi,
>
> I really wonder why it is useful to add a skip-parameter to the packaging
> plugin? The goal for every Maven project is to end up with some (packaged)
> artifact, right?
> A skip-parameter because a lot of other plugins have it as well is IMHO
> not a good reason, so what would be a valid usecase here?
>
> thanks,
> Robert
>
> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA) <
> jira@apache.org>:
>
>
>> [
>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Karl Heinz Marbaise closed MWAR-350.
>> ------------------------------------
>> Resolution: Fixed
>> Assignee: Karl Heinz Marbaise
>>
>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>
>> Add Skip Parameter to Skip the process
>>> --------------------------------------
>>>
>>> Key: MWAR-350
>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>> Project: Maven WAR Plugin
>>> Issue Type: New Feature
>>> Affects Versions: 2.6
>>> Environment: Maven 3.3.3
>>> maven-war-plugin 2.6
>>> Reporter: Keshan De Silva
>>> Assignee: Karl Heinz Marbaise
>>> Priority: Trivial
>>> Fix For: 3.0.0
>>>
>>> Attachments: Maven_War_Skip.patch
>>>
>>>
>>> * It will be usefull if maven-war plugin has a skip configuration as in
>>> most of the plugins have.
>>> {code:xml}
>>> <groupId>org.apache.maven.plugins</groupId>
>>> <artifactId>maven-war-plugin</artifactId>
>>> <version>2.6</version>
>>> <configuration>
>>> <skip>true</skip>
>>> </configuration>
>>> {code}
>>> (I have attached a patch file)
>>>
>>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2016-01-25 21:39 GMT+01:00 Robert Scholte <rf...@apache.org>:
> Op Mon, 25 Jan 2016 21:05:58 +0100 schreef Romain Manni-Bucau <
> rmannibucau@gmail.com>:
>
> Nothing prevents to build 2 or more wars with slightly different resources.
>> Being able to skip one would be useful.
>>
>
> That should mean different artifactIds (and groupIds or versions?), so
> different projects/modules. And you always have the option to decide which
> modules to build.
>
>
having several modules for that is most of the time overkill or enforce to
use overlays which are slow and can be avoided. Builderhelper plugin is a
better approach most of the time.
> I think that for every example where people want to skip the packaging of
> an artifact, we have (or should have) a better pattern to accomplish that.
>
>
And if you consider maven-war-plugin as a real plugin and not the packaging
of your pom - which is already doable today?
> thanks,
> Robert
>
>
> Le 25 janv. 2016 20:58, "Robert Scholte" <rf...@apache.org> a écrit :
>>
>> Op Mon, 25 Jan 2016 20:55:09 +0100 schreef jieryn <ji...@gmail.com>:
>>>
>>> UAT module which is war for easy overlay of the main WAR module but
>>>
>>>> without double-pushing your (fat) war into the upstream repository?
>>>>
>>>>
>>>> Both install:install and deploy:deploy have skip parameters for that
>>> reason. AFAIK overlay still needs the war.
>>>
>>> Robert
>>>
>>>
>>> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
>>>
>>>> wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> I really wonder why it is useful to add a skip-parameter to the
>>>>> packaging
>>>>> plugin? The goal for every Maven project is to end up with some
>>>>> (packaged)
>>>>> artifact, right?
>>>>> A skip-parameter because a lot of other plugins have it as well is IMHO
>>>>> not
>>>>> a good reason, so what would be a valid usecase here?
>>>>>
>>>>> thanks,
>>>>> Robert
>>>>>
>>>>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>>>>> <ji...@apache.org>:
>>>>>
>>>>>
>>>>> [
>>>>>>
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>>>> ]
>>>>>>
>>>>>> Karl Heinz Marbaise closed MWAR-350.
>>>>>> ------------------------------------
>>>>>> Resolution: Fixed
>>>>>> Assignee: Karl Heinz Marbaise
>>>>>>
>>>>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>>>>
>>>>>> Add Skip Parameter to Skip the process
>>>>>>
>>>>>>> --------------------------------------
>>>>>>>
>>>>>>> Key: MWAR-350
>>>>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>>>>> Project: Maven WAR Plugin
>>>>>>> Issue Type: New Feature
>>>>>>> Affects Versions: 2.6
>>>>>>> Environment: Maven 3.3.3
>>>>>>> maven-war-plugin 2.6
>>>>>>> Reporter: Keshan De Silva
>>>>>>> Assignee: Karl Heinz Marbaise
>>>>>>> Priority: Trivial
>>>>>>> Fix For: 3.0.0
>>>>>>>
>>>>>>> Attachments: Maven_War_Skip.patch
>>>>>>>
>>>>>>>
>>>>>>> * It will be usefull if maven-war plugin has a skip configuration as
>>>>>>> in
>>>>>>> most of the plugins have.
>>>>>>> {code:xml}
>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>> <artifactId>maven-war-plugin</artifactId>
>>>>>>> <version>2.6</version>
>>>>>>> <configuration>
>>>>>>> <skip>true</skip>
>>>>>>> </configuration>
>>>>>>> {code}
>>>>>>> (I have attached a patch file)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> This message was sent by Atlassian JIRA
>>>>>> (v6.3.4#6332)
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Robert Scholte <rf...@apache.org>.
Op Mon, 25 Jan 2016 21:05:58 +0100 schreef Romain Manni-Bucau
<rm...@gmail.com>:
> Nothing prevents to build 2 or more wars with slightly different
> resources.
> Being able to skip one would be useful.
That should mean different artifactIds (and groupIds or versions?), so
different projects/modules. And you always have the option to decide which
modules to build.
I think that for every example where people want to skip the packaging of
an artifact, we have (or should have) a better pattern to accomplish that.
thanks,
Robert
> Le 25 janv. 2016 20:58, "Robert Scholte" <rf...@apache.org> a écrit :
>
>> Op Mon, 25 Jan 2016 20:55:09 +0100 schreef jieryn <ji...@gmail.com>:
>>
>> UAT module which is war for easy overlay of the main WAR module but
>>> without double-pushing your (fat) war into the upstream repository?
>>>
>>>
>> Both install:install and deploy:deploy have skip parameters for that
>> reason. AFAIK overlay still needs the war.
>>
>> Robert
>>
>>
>> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I really wonder why it is useful to add a skip-parameter to the
>>>> packaging
>>>> plugin? The goal for every Maven project is to end up with some
>>>> (packaged)
>>>> artifact, right?
>>>> A skip-parameter because a lot of other plugins have it as well is
>>>> IMHO
>>>> not
>>>> a good reason, so what would be a valid usecase here?
>>>>
>>>> thanks,
>>>> Robert
>>>>
>>>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>>>> <ji...@apache.org>:
>>>>
>>>>
>>>>> [
>>>>>
>>>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>>> ]
>>>>>
>>>>> Karl Heinz Marbaise closed MWAR-350.
>>>>> ------------------------------------
>>>>> Resolution: Fixed
>>>>> Assignee: Karl Heinz Marbaise
>>>>>
>>>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>>>
>>>>> Add Skip Parameter to Skip the process
>>>>>> --------------------------------------
>>>>>>
>>>>>> Key: MWAR-350
>>>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>>>> Project: Maven WAR Plugin
>>>>>> Issue Type: New Feature
>>>>>> Affects Versions: 2.6
>>>>>> Environment: Maven 3.3.3
>>>>>> maven-war-plugin 2.6
>>>>>> Reporter: Keshan De Silva
>>>>>> Assignee: Karl Heinz Marbaise
>>>>>> Priority: Trivial
>>>>>> Fix For: 3.0.0
>>>>>>
>>>>>> Attachments: Maven_War_Skip.patch
>>>>>>
>>>>>>
>>>>>> * It will be usefull if maven-war plugin has a skip configuration
>>>>>> as in
>>>>>> most of the plugins have.
>>>>>> {code:xml}
>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>> <artifactId>maven-war-plugin</artifactId>
>>>>>> <version>2.6</version>
>>>>>> <configuration>
>>>>>> <skip>true</skip>
>>>>>> </configuration>
>>>>>> {code}
>>>>>> (I have attached a patch file)
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian JIRA
>>>>> (v6.3.4#6332)
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Nothing prevents to build 2 or more wars with slightly different resources.
Being able to skip one would be useful.
Le 25 janv. 2016 20:58, "Robert Scholte" <rf...@apache.org> a écrit :
> Op Mon, 25 Jan 2016 20:55:09 +0100 schreef jieryn <ji...@gmail.com>:
>
> UAT module which is war for easy overlay of the main WAR module but
>> without double-pushing your (fat) war into the upstream repository?
>>
>>
> Both install:install and deploy:deploy have skip parameters for that
> reason. AFAIK overlay still needs the war.
>
> Robert
>
>
> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>>
>>> Hi,
>>>
>>> I really wonder why it is useful to add a skip-parameter to the packaging
>>> plugin? The goal for every Maven project is to end up with some
>>> (packaged)
>>> artifact, right?
>>> A skip-parameter because a lot of other plugins have it as well is IMHO
>>> not
>>> a good reason, so what would be a valid usecase here?
>>>
>>> thanks,
>>> Robert
>>>
>>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>>> <ji...@apache.org>:
>>>
>>>
>>>> [
>>>>
>>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>> ]
>>>>
>>>> Karl Heinz Marbaise closed MWAR-350.
>>>> ------------------------------------
>>>> Resolution: Fixed
>>>> Assignee: Karl Heinz Marbaise
>>>>
>>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>>
>>>> Add Skip Parameter to Skip the process
>>>>> --------------------------------------
>>>>>
>>>>> Key: MWAR-350
>>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>>> Project: Maven WAR Plugin
>>>>> Issue Type: New Feature
>>>>> Affects Versions: 2.6
>>>>> Environment: Maven 3.3.3
>>>>> maven-war-plugin 2.6
>>>>> Reporter: Keshan De Silva
>>>>> Assignee: Karl Heinz Marbaise
>>>>> Priority: Trivial
>>>>> Fix For: 3.0.0
>>>>>
>>>>> Attachments: Maven_War_Skip.patch
>>>>>
>>>>>
>>>>> * It will be usefull if maven-war plugin has a skip configuration as in
>>>>> most of the plugins have.
>>>>> {code:xml}
>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>> <artifactId>maven-war-plugin</artifactId>
>>>>> <version>2.6</version>
>>>>> <configuration>
>>>>> <skip>true</skip>
>>>>> </configuration>
>>>>> {code}
>>>>> (I have attached a patch file)
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Robert Scholte <rf...@apache.org>.
Op Mon, 25 Jan 2016 20:55:09 +0100 schreef jieryn <ji...@gmail.com>:
> UAT module which is war for easy overlay of the main WAR module but
> without double-pushing your (fat) war into the upstream repository?
>
Both install:install and deploy:deploy have skip parameters for that
reason. AFAIK overlay still needs the war.
Robert
> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
> wrote:
>> Hi,
>>
>> I really wonder why it is useful to add a skip-parameter to the
>> packaging
>> plugin? The goal for every Maven project is to end up with some
>> (packaged)
>> artifact, right?
>> A skip-parameter because a lot of other plugins have it as well is IMHO
>> not
>> a good reason, so what would be a valid usecase here?
>>
>> thanks,
>> Robert
>>
>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>> <ji...@apache.org>:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Karl Heinz Marbaise closed MWAR-350.
>>> ------------------------------------
>>> Resolution: Fixed
>>> Assignee: Karl Heinz Marbaise
>>>
>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>
>>>> Add Skip Parameter to Skip the process
>>>> --------------------------------------
>>>>
>>>> Key: MWAR-350
>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>> Project: Maven WAR Plugin
>>>> Issue Type: New Feature
>>>> Affects Versions: 2.6
>>>> Environment: Maven 3.3.3
>>>> maven-war-plugin 2.6
>>>> Reporter: Keshan De Silva
>>>> Assignee: Karl Heinz Marbaise
>>>> Priority: Trivial
>>>> Fix For: 3.0.0
>>>>
>>>> Attachments: Maven_War_Skip.patch
>>>>
>>>>
>>>> * It will be usefull if maven-war plugin has a skip configuration as
>>>> in
>>>> most of the plugins have.
>>>> {code:xml}
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-war-plugin</artifactId>
>>>> <version>2.6</version>
>>>> <configuration>
>>>> <skip>true</skip>
>>>> </configuration>
>>>> {code}
>>>> (I have attached a patch file)
>>>>
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by jieryn <ji...@gmail.com>.
UAT module which is war for easy overlay of the main WAR module but
without double-pushing your (fat) war into the upstream repository?
On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org> wrote:
> Hi,
>
> I really wonder why it is useful to add a skip-parameter to the packaging
> plugin? The goal for every Maven project is to end up with some (packaged)
> artifact, right?
> A skip-parameter because a lot of other plugins have it as well is IMHO not
> a good reason, so what would be a valid usecase here?
>
> thanks,
> Robert
>
> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
> <ji...@apache.org>:
>
>>
>> [
>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Karl Heinz Marbaise closed MWAR-350.
>> ------------------------------------
>> Resolution: Fixed
>> Assignee: Karl Heinz Marbaise
>>
>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>
>>> Add Skip Parameter to Skip the process
>>> --------------------------------------
>>>
>>> Key: MWAR-350
>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>> Project: Maven WAR Plugin
>>> Issue Type: New Feature
>>> Affects Versions: 2.6
>>> Environment: Maven 3.3.3
>>> maven-war-plugin 2.6
>>> Reporter: Keshan De Silva
>>> Assignee: Karl Heinz Marbaise
>>> Priority: Trivial
>>> Fix For: 3.0.0
>>>
>>> Attachments: Maven_War_Skip.patch
>>>
>>>
>>> * It will be usefull if maven-war plugin has a skip configuration as in
>>> most of the plugins have.
>>> {code:xml}
>>> <groupId>org.apache.maven.plugins</groupId>
>>> <artifactId>maven-war-plugin</artifactId>
>>> <version>2.6</version>
>>> <configuration>
>>> <skip>true</skip>
>>> </configuration>
>>> {code}
>>> (I have attached a patch file)
>>>
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Michael Osipov <mi...@apache.org>.
Am 2016-01-26 um 12:05 schrieb Adrien Rivard:
> Hi,
>
> My opinon on that is that you do not need to build actual wars(neither jar
> btw) at all when you are developping within Eclipse.
> Jetty and tomcat can run on exploded was strucure, and most others servers
> have some eclipse tooling.
>
> With a combination of eclipse configuration mecanism,(launch configuration
> ...), external to war configuration, and simple custom java code, you
> should be able to put a solution to your needs.
Can you explain a bit how you solved the problem for you?
I do not even use the explode feature. I simply use Eclipse's Tomcat
support along with JRebel and the WAR project. m2e and m2e-wtp make it
happen. No copying necessary.
Michael
> On Mon, Jan 25, 2016 at 9:49 PM, Michael Osipov <mi...@apache.org> wrote:
>
>> Am 2016-01-25 um 20:51 schrieb Robert Scholte:
>>
>>> Hi,
>>>
>>> I really wonder why it is useful to add a skip-parameter to the
>>> packaging plugin? The goal for every Maven project is to end up with
>>> some (packaged) artifact, right?
>>> A skip-parameter because a lot of other plugins have it as well is IMHO
>>> not a good reason, so what would be a valid usecase here?
>>>
>>
>> Building WAR files are a constant problem. I do have them myself.
>>
>> Consider you have a WAR project you are using to develop within Eclipse.
>> Now you need a different one for every deployment site/configuration. Only
>> few files are different but you need separate WAR files. How to solve this?
>>
>> They are obviously several ways and all have issues. The reporter of
>> MWAR-350 tries to solve it.
>>
>> We should probably create a documentation site which describes how to
>> solve this problem. I have currently three different ways and none of them
>> satisfy me.
>>
>> Michael
>>
>>
>>
>> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>>> <ji...@apache.org>:
>>>
>>>
>>>> [
>>>>
>>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>> ]
>>>>
>>>> Karl Heinz Marbaise closed MWAR-350.
>>>> ------------------------------------
>>>> Resolution: Fixed
>>>> Assignee: Karl Heinz Marbaise
>>>>
>>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>>
>>>> Add Skip Parameter to Skip the process
>>>>> --------------------------------------
>>>>>
>>>>> Key: MWAR-350
>>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>>> Project: Maven WAR Plugin
>>>>> Issue Type: New Feature
>>>>> Affects Versions: 2.6
>>>>> Environment: Maven 3.3.3
>>>>> maven-war-plugin 2.6
>>>>> Reporter: Keshan De Silva
>>>>> Assignee: Karl Heinz Marbaise
>>>>> Priority: Trivial
>>>>> Fix For: 3.0.0
>>>>>
>>>>> Attachments: Maven_War_Skip.patch
>>>>>
>>>>>
>>>>> * It will be usefull if maven-war plugin has a skip configuration as
>>>>> in most of the plugins have.
>>>>> {code:xml}
>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>> <artifactId>maven-war-plugin</artifactId>
>>>>> <version>2.6</version>
>>>>> <configuration>
>>>>> <skip>true</skip>
>>>>> </configuration>
>>>>> {code}
>>>>> (I have attached a patch file)
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Adrien Rivard <ad...@gmail.com>.
Hi,
My opinon on that is that you do not need to build actual wars(neither jar
btw) at all when you are developping within Eclipse.
Jetty and tomcat can run on exploded was strucure, and most others servers
have some eclipse tooling.
With a combination of eclipse configuration mecanism,(launch configuration
...), external to war configuration, and simple custom java code, you
should be able to put a solution to your needs.
On Mon, Jan 25, 2016 at 9:49 PM, Michael Osipov <mi...@apache.org> wrote:
> Am 2016-01-25 um 20:51 schrieb Robert Scholte:
>
>> Hi,
>>
>> I really wonder why it is useful to add a skip-parameter to the
>> packaging plugin? The goal for every Maven project is to end up with
>> some (packaged) artifact, right?
>> A skip-parameter because a lot of other plugins have it as well is IMHO
>> not a good reason, so what would be a valid usecase here?
>>
>
> Building WAR files are a constant problem. I do have them myself.
>
> Consider you have a WAR project you are using to develop within Eclipse.
> Now you need a different one for every deployment site/configuration. Only
> few files are different but you need separate WAR files. How to solve this?
>
> They are obviously several ways and all have issues. The reporter of
> MWAR-350 tries to solve it.
>
> We should probably create a documentation site which describes how to
> solve this problem. I have currently three different ways and none of them
> satisfy me.
>
> Michael
>
>
>
> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
>> <ji...@apache.org>:
>>
>>
>>> [
>>>
>>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Karl Heinz Marbaise closed MWAR-350.
>>> ------------------------------------
>>> Resolution: Fixed
>>> Assignee: Karl Heinz Marbaise
>>>
>>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>>
>>> Add Skip Parameter to Skip the process
>>>> --------------------------------------
>>>>
>>>> Key: MWAR-350
>>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>>> Project: Maven WAR Plugin
>>>> Issue Type: New Feature
>>>> Affects Versions: 2.6
>>>> Environment: Maven 3.3.3
>>>> maven-war-plugin 2.6
>>>> Reporter: Keshan De Silva
>>>> Assignee: Karl Heinz Marbaise
>>>> Priority: Trivial
>>>> Fix For: 3.0.0
>>>>
>>>> Attachments: Maven_War_Skip.patch
>>>>
>>>>
>>>> * It will be usefull if maven-war plugin has a skip configuration as
>>>> in most of the plugins have.
>>>> {code:xml}
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-war-plugin</artifactId>
>>>> <version>2.6</version>
>>>> <configuration>
>>>> <skip>true</skip>
>>>> </configuration>
>>>> {code}
>>>> (I have attached a patch file)
>>>>
>>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Adrien Rivard
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Michael Osipov <mi...@apache.org>.
Am 2016-01-25 um 20:51 schrieb Robert Scholte:
> Hi,
>
> I really wonder why it is useful to add a skip-parameter to the
> packaging plugin? The goal for every Maven project is to end up with
> some (packaged) artifact, right?
> A skip-parameter because a lot of other plugins have it as well is IMHO
> not a good reason, so what would be a valid usecase here?
Building WAR files are a constant problem. I do have them myself.
Consider you have a WAR project you are using to develop within Eclipse.
Now you need a different one for every deployment site/configuration.
Only few files are different but you need separate WAR files. How to
solve this?
They are obviously several ways and all have issues. The reporter of
MWAR-350 tries to solve it.
We should probably create a documentation site which describes how to
solve this problem. I have currently three different ways and none of
them satisfy me.
Michael
> Op Mon, 25 Jan 2016 20:28:39 +0100 schreef Karl Heinz Marbaise (JIRA)
> <ji...@apache.org>:
>
>>
>> [
>> https://issues.apache.org/jira/browse/MWAR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Karl Heinz Marbaise closed MWAR-350.
>> ------------------------------------
>> Resolution: Fixed
>> Assignee: Karl Heinz Marbaise
>>
>> Fixed in [r1726671|http://svn.apache.org/r1726671]
>>
>>> Add Skip Parameter to Skip the process
>>> --------------------------------------
>>>
>>> Key: MWAR-350
>>> URL: https://issues.apache.org/jira/browse/MWAR-350
>>> Project: Maven WAR Plugin
>>> Issue Type: New Feature
>>> Affects Versions: 2.6
>>> Environment: Maven 3.3.3
>>> maven-war-plugin 2.6
>>> Reporter: Keshan De Silva
>>> Assignee: Karl Heinz Marbaise
>>> Priority: Trivial
>>> Fix For: 3.0.0
>>>
>>> Attachments: Maven_War_Skip.patch
>>>
>>>
>>> * It will be usefull if maven-war plugin has a skip configuration as
>>> in most of the plugins have.
>>> {code:xml}
>>> <groupId>org.apache.maven.plugins</groupId>
>>> <artifactId>maven-war-plugin</artifactId>
>>> <version>2.6</version>
>>> <configuration>
>>> <skip>true</skip>
>>> </configuration>
>>> {code}
>>> (I have attached a patch file)
>>>
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Robert Scholte <rf...@apache.org>.
Op Tue, 26 Jan 2016 14:29:15 +0100 schreef Paul Benedict
<pb...@apache.org>:
> I'm more curious of the growth of "skip" parameters of plugins. Do they
> exist really to skip the plugin, or are they really representative of the
> desire to skip an entire phase?
> On Jan 25, 2016 7:24 PM, "Christopher" <ct...@apache.org> wrote:
>
I'm curious that growth too. It could also mean that we do something wrong.
I've been talking with Karl-Heinz about this and his reason is interesting.
He has a huge multimodule project, which he wants to deploy in the end,
but actually he's first interested if the changes make the whole project
still compilable.
Also in this case the skip parameter is a hack. Instead the lifecycle
handling should be improved, so users can specify the phases which should
be executed first before continuing. This requirement seems to be an extra
feature for MNG-5885[1].
thanks,
Robert
[1] https://issues.apache.org/jira/browse/MNG-5885
>> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
>> wrote:
>> > Hi,
>> >
>> > I really wonder why it is useful to add a skip-parameter to the
>> packaging
>> > plugin? The goal for every Maven project is to end up with some
>> (packaged)
>> > artifact, right?
>> > A skip-parameter because a lot of other plugins have it as well is
>> IMHO
>> not
>> > a good reason, so what would be a valid usecase here?
>> >
>>
>> I would argue that it's useful to be able to skip over arbitrary
>> plugins, regardless of what they do, simply for testing other parts of
>> the build.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Christopher <ct...@apache.org>.
On Tue, Jan 26, 2016 at 8:29 AM Paul Benedict <pb...@apache.org> wrote:
> I'm more curious of the growth of "skip" parameters of plugins. Do they
> exist really to skip the plugin, or are they really representative of the
> desire to skip an entire phase?
>
> [snip]
I frequently disable a subset of plugins which run at the "package"
(usually supplemental artifacts, like javadoc jars or source jars) or
"verify" phase (like findbugs or checkstyle), for testing, while leaving
others enabled.
While I can imagine it would be useful to skip an entire phase in some
situations, I've never encountered the desire to do so. It might be an
interesting feature to have in the toolkit, though.
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Paul Benedict <pb...@apache.org>.
I'm more curious of the growth of "skip" parameters of plugins. Do they
exist really to skip the plugin, or are they really representative of the
desire to skip an entire phase?
On Jan 25, 2016 7:24 PM, "Christopher" <ct...@apache.org> wrote:
> On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org>
> wrote:
> > Hi,
> >
> > I really wonder why it is useful to add a skip-parameter to the packaging
> > plugin? The goal for every Maven project is to end up with some
> (packaged)
> > artifact, right?
> > A skip-parameter because a lot of other plugins have it as well is IMHO
> not
> > a good reason, so what would be a valid usecase here?
> >
>
> I would argue that it's useful to be able to skip over arbitrary
> plugins, regardless of what they do, simply for testing other parts of
> the build.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [jira] [Closed] (MWAR-350) Add Skip Parameter to Skip the process
Posted by Christopher <ct...@apache.org>.
On Mon, Jan 25, 2016 at 2:51 PM, Robert Scholte <rf...@apache.org> wrote:
> Hi,
>
> I really wonder why it is useful to add a skip-parameter to the packaging
> plugin? The goal for every Maven project is to end up with some (packaged)
> artifact, right?
> A skip-parameter because a lot of other plugins have it as well is IMHO not
> a good reason, so what would be a valid usecase here?
>
I would argue that it's useful to be able to skip over arbitrary
plugins, regardless of what they do, simply for testing other parts of
the build.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org