You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:08:01 UTC
[GitHub] [pulsar] sijia-w opened a new pull request #11896: [docs] Update compaction metrics in 282
sijia-w opened a new pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896
This is a follow-up of #11739.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11896: [docs] Update compaction metrics in 282
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896#issuecomment-912296229
@Anonymitaet I modified the doc in 2.8.2, and then I updated the changes to master. So this pr covers changes to both versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11896: [docs] Update compaction metrics in 282
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896#issuecomment-912295344
@Anonymitaet I prefer to not use the parenthesis, that way, "in bytes" looks like a note. The main info in this sentence is still "the total number of messages".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11896: [docs] Update compaction metrics in 282
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896#discussion_r701521809
##########
File path: site2/docs/reference-metrics.md
##########
@@ -200,20 +200,19 @@ All the topic metrics are labelled with the following labels:
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
| pulsar_storage_write_latency_le_* | Histogram | The entry rate of a topic that the storage write latency is smaller with a given threshold.<br> Available thresholds: <br><ul><li>pulsar_storage_write_latency_le_0_5: <= 0.5ms </li><li>pulsar_storage_write_latency_le_1: <= 1ms</li><li>pulsar_storage_write_latency_le_5: <= 5ms</li><li>pulsar_storage_write_latency_le_10: <= 10ms</li><li>pulsar_storage_write_latency_le_20: <= 20ms</li><li>pulsar_storage_write_latency_le_50: <= 50ms</li><li>pulsar_storage_write_latency_le_100: <= 100ms</li><li>pulsar_storage_write_latency_le_200: <= 200ms</li><li>pulsar_storage_write_latency_le_1000: <= 1s</li><li>pulsar_storage_write_latency_le_overflow: > 1s</li></ul> |
| pulsar_entry_size_le_* | Histogram | The entry rate of a topic that the entry size is smaller with a given threshold.<br> Available thresholds: <br><ul><li>pulsar_entry_size_le_128: <= 128 bytes </li><li>pulsar_entry_size_le_512: <= 512 bytes</li><li>pulsar_entry_size_le_1_kb: <= 1 KB</li><li>pulsar_entry_size_le_2_kb: <= 2 KB</li><li>pulsar_entry_size_le_4_kb: <= 4 KB</li><li>pulsar_entry_size_le_16_kb: <= 16 KB</li><li>pulsar_entry_size_le_100_kb: <= 100 KB</li><li>pulsar_entry_size_le_1_mb: <= 1 MB</li><li>pulsar_entry_size_le_overflow: > 1 MB</li></ul> |
-| pulsar_in_bytes_total | Counter | The total number of bytes received for this topic |
-| pulsar_in_messages_total | Counter | The total number of messages received for this topic |
-| pulsar_out_bytes_total | Counter | The total number of bytes read from this topic |
-| pulsar_out_messages_total | Counter | The total number of messages read from this topic |
-| pulsar_compaction_removed_event_count | Gauge | The removed event count of compaction |
-| pulsar_compaction_succeed_count | Gauge | The succeed count of compaction |
-| pulsar_compaction_failed_count | Gauge | The failed count of compaction |
-| pulsar_compaction_duration_time_in_mills | Gauge | The duration time of compaction |
-| pulsar_compaction_read_throughput | Gauge | The read throughput of compaction |
-| pulsar_compaction_write_throughput | Gauge | The write throughput of compaction |
+| pulsar_in_bytes_total | Counter | The total number of messages in bytes received for this topic. |
Review comment:
```suggestion
| pulsar_in_bytes_total | Counter | The total number of messages received for this topic (in bytes). |
```
if agree, please update all, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #11896: [docs] Update compaction metrics in 282
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896#issuecomment-911430294
@Technoboy- @Anonymitaet Please help review the changes and leave a comment if anything should be modified. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #11896: [docs] Update compaction metrics in 282
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #11896:
URL: https://github.com/apache/pulsar/pull/11896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org