You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/12/19 19:15:32 UTC
[GitHub] flink pull request: [FLINK-3185] [runtime, tests] Log error on fai...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1472
[FLINK-3185] [runtime, tests] Log error on failure during recovery
A failure during job recovery was not logged by the future executing the recovery. This led a user to think that recovery was not happening at all.
Furthermore, some log messages have been improved and a test was fixed, which was not failing, but only printing the stack trace on failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3185-silence_of_the_ha_lambs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit 698e4eb8dee63751a53b8202436b59479b25a344
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-12-18T13:49:19Z
[FLINK-3185] [tests] Don't swallow test failure Exception
commit c991fba6c6325efbb835c4f419b4204d8664a5a9
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-12-16T23:06:17Z
[FLINK-3185] [runtime, tests] Log error on failure during recovery
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3185] [runtime, tests] Log error on fai...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1472#issuecomment-166934978
+1, will merge this, address Till's comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3185] [runtime, tests] Log error on fai...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3185] [runtime, tests] Log error on fai...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1472#issuecomment-166331038
Good fix @uce. +1 for merging :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3185] [runtime, tests] Log error on fai...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1472#discussion_r48155515
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -245,6 +245,8 @@ class JobManager(
// TODO (critical next step) This needs to be more flexible and robust (e.g. wait for task
// managers etc.)
if (recoveryMode != RecoveryMode.STANDALONE) {
+ log.info(s"Delaying recovery of all jobs for ${delayBetweenRetries} ms.")
--- End diff --
Unnecessary curly brackets. Should be shown as an Intellij warning if enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---