You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/06/09 21:05:42 UTC
[GitHub] [pinot] walterddr opened a new pull request, #10881: [hotfix][multistage] fix PB operator never returns block
walterddr opened a new pull request, #10881:
URL: https://github.com/apache/pinot/pull/10881
this PR addresses a non-yielding problem for pipeline breaker that causes extreme thread fairness issue when cluster is under load.
Before
---
After
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10881: [multistage][bugfix] fix PB operator never returns block
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10881:
URL: https://github.com/apache/pinot/pull/10881#discussion_r1224895260
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerOperator.java:
##########
@@ -79,14 +79,14 @@ protected TransferableBlock getNextBlock() {
Map.Entry<Integer, Operator<TransferableBlock>> worker = _workerEntries.remove();
TransferableBlock block = worker.getValue().nextBlock();
- // Release the mailbox when the block is end-of-stream
- if (block != null && block.isSuccessfulEndOfStreamBlock()) {
+ // Release the mailbox worker when the block is end-of-stream
+ if (block != null && !block.isNoOpBlock() && block.isSuccessfulEndOfStreamBlock()) {
Review Comment:
```suggestion
if (block != null && block.isSuccessfulEndOfStreamBlock()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10881: [multistage][bugfix] fix PB operator never returns block
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10881:
URL: https://github.com/apache/pinot/pull/10881#issuecomment-1585160140
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10881](https://app.codecov.io/gh/apache/pinot/pull/10881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (358c789) into [master](https://app.codecov.io/gh/apache/pinot/commit/03c49e43b4f20f1248ecdbabf6359b59b388455a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (03c49e4) will **decrease** coverage by `70.12%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10881 +/- ##
=============================================
- Coverage 70.23% 0.11% -70.12%
=============================================
Files 2174 2132 -42
Lines 116880 114849 -2031
Branches 17702 17428 -274
=============================================
- Hits 82085 137 -81948
- Misses 29062 114692 +85630
+ Partials 5733 20 -5713
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
| unittests2temurin11 | `0.11% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...runtime/plan/pipeline/PipelineBreakerOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9wbGFuL3BpcGVsaW5lL1BpcGVsaW5lQnJlYWtlck9wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-55.89%)` | :arrow_down: |
... and [1984 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10881/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #10881: [multistage][bugfix] fix PB operator never returns block
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #10881:
URL: https://github.com/apache/pinot/pull/10881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org