You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/08 03:17:59 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10236: Update example on docs/howto/connection/index.rst
mik-laj opened a new pull request #10236:
URL: https://github.com/apache/airflow/pull/10236
CC: @rootcss
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10236: Update example on docs/howto/connection/index.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10236:
URL: https://github.com/apache/airflow/pull/10236#issuecomment-670850533
@rootcss Thanks you. I updated this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10236: Update example on docs/howto/connection/index.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10236:
URL: https://github.com/apache/airflow/pull/10236#discussion_r467354655
##########
File path: docs/howto/connection/index.rst
##########
@@ -118,62 +118,53 @@ The JSON format contains an object where the key contains the connection ID and
.. code-block:: json
{
- "CONN_A": {
- "conn_type": "mysql",
- "host": "mysql",
- "login": "root",
- "password": "plainpassword",
- "schema": "airflow",
- "port": null,
- "extra": null,
- "is_encrypted": false,
- "is_extra_encrypted": false
- },
- "CONN_B": {
- "conn_type": "druid",
- "host": "druid-broker",
- "login": null,
- "password": null,
- "schema": null,
- "port": 8082,
- "extra": "{\"endpoint\": \"druid/v2/sql\"}",
- "is_encrypted": false,
- "is_extra_encrypted": false
- }
+ "airflow_db": {
+ "conn_type": "mysql",
+ "host": "mysql",
+ "login": "root",
+ "password": "plainpassword",
+ "schema": "airflow",
+ "port": null,
+ "extra": null
+ },
+ "druid_broker_default": {
+ "conn_type": "druid",
+ "host": "druid-broker",
+ "login": null,
+ "password": null,
+ "schema": null,
+ "port": 8082,
+ "extra": "{\"endpoint\": \"druid/v2/sql\"}"
+ }
}
The YAML file structure is similar to that of a JSON. The key-value pair of connection ID and the definitions of one or more connections. In this format, the connection is defined as a YAML object. The following is a sample YAML file.
.. code-block:: yaml
- CONN_A:
+ airflow_db:
conn_type: mysql
- extra:
+ extra: null
host: mysql
- is_encrypted: false
- is_extra_encrypted: false
login: root
password: plainpassword
- port:
+ port: null
schema: airflow
-
- CONN_B:
+ druid_broker_default:
conn_type: druid
extra: '{"endpoint": "druid/v2/sql"}'
host: druid-broker
- is_encrypted: false
Review comment:
These fields do not exist in the output file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rootcss commented on a change in pull request #10236: Update example on docs/howto/connection/index.rst
Posted by GitBox <gi...@apache.org>.
rootcss commented on a change in pull request #10236:
URL: https://github.com/apache/airflow/pull/10236#discussion_r467368131
##########
File path: docs/howto/connection/index.rst
##########
@@ -118,62 +118,53 @@ The JSON format contains an object where the key contains the connection ID and
.. code-block:: json
{
- "CONN_A": {
- "conn_type": "mysql",
- "host": "mysql",
- "login": "root",
- "password": "plainpassword",
- "schema": "airflow",
- "port": null,
- "extra": null,
- "is_encrypted": false,
- "is_extra_encrypted": false
- },
- "CONN_B": {
- "conn_type": "druid",
- "host": "druid-broker",
- "login": null,
- "password": null,
- "schema": null,
- "port": 8082,
- "extra": "{\"endpoint\": \"druid/v2/sql\"}",
- "is_encrypted": false,
- "is_extra_encrypted": false
- }
+ "airflow_db": {
+ "conn_type": "mysql",
+ "host": "mysql",
+ "login": "root",
+ "password": "plainpassword",
+ "schema": "airflow",
+ "port": null,
+ "extra": null
+ },
+ "druid_broker_default": {
+ "conn_type": "druid",
+ "host": "druid-broker",
+ "login": null,
+ "password": null,
+ "schema": null,
+ "port": 8082,
+ "extra": "{\"endpoint\": \"druid/v2/sql\"}"
+ }
}
The YAML file structure is similar to that of a JSON. The key-value pair of connection ID and the definitions of one or more connections. In this format, the connection is defined as a YAML object. The following is a sample YAML file.
.. code-block:: yaml
- CONN_A:
+ airflow_db:
conn_type: mysql
- extra:
+ extra: null
host: mysql
- is_encrypted: false
- is_extra_encrypted: false
login: root
password: plainpassword
- port:
+ port: null
schema: airflow
-
- CONN_B:
+ druid_broker_default:
conn_type: druid
extra: '{"endpoint": "druid/v2/sql"}'
host: druid-broker
- is_encrypted: false
Review comment:
Ah! missed that. I had removed both of those fields in later version. Thanks 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10236: Update example on docs/howto/connection/index.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10236:
URL: https://github.com/apache/airflow/pull/10236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rootcss commented on pull request #10236: Update example on docs/howto/connection/index.rst
Posted by GitBox <gi...@apache.org>.
rootcss commented on pull request #10236:
URL: https://github.com/apache/airflow/pull/10236#issuecomment-670831004
@mik-laj tests have failed due to missing indent in tests' connections dict. https://github.com/apache/airflow/pull/10236/checks?check_run_id=960763585#step:6:1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org