[GitHub] [iceberg] fqaiser94 commented on issue #6514: Support Conditional Transaction Commits

[GitBox <gi...@apache.org>]

fqaiser94 commented on issue #6514:
URL: https://github.com/apache/iceberg/issues/6514#issuecomment-1374910722

   Thanks for your response @rdblue!
   
   > What I recommend to accomplish the use case you're talking about is putting the watermark in snapshot properties instead of table properties. 
   
   Thanks for your advice. 
   It might be an option for us but I'll have to think some more about it. 
   I had some concerns about losing those watermarks due to snapshot expiration.
   Was also mildly concerned about how expensive it might be to have to search previous snapshots on every commit (assuming that involves multiple network calls). 
   Regardless, have to get this feature in first though!
   
   > I'd add a `validate(Predicate<TableMetadata> current)` to either `SnapshotUpdate`, or the more general `PendingUpdate`.
   
   Yea, I was considering this too. 
   
   Sounds like we are both more or less in alignment so I'll try reworking my PR to implement it in the way you suggested, might take me a few weeks so please bear with me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org