You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/23 03:57:54 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #6002: [INLONG-6001][Manager] Ensure that the newly created sink under the successfully configured stream can be configured normally
fuweng11 opened a new pull request, #6002:
URL: https://github.com/apache/inlong/pull/6002
### Prepare a Pull Request
- Fixes #6001
### Motivation
Ensure that the newly created sink under the successfully configured stream can be configured normally
### Modifications
Judge the stream status when saving. If the configuration is successful, the sink configuration process will be triggered
### Verifying this change
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6002: [INLONG-6001][Manager] Ensure that the newly created sink under the successful stream can be configured normally
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6002:
URL: https://github.com/apache/inlong/pull/6002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6002: [INLONG-6001][Manager] Ensure that the newly created sink under the successfully configured stream can be configured normally
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6002:
URL: https://github.com/apache/inlong/pull/6002#discussion_r978423964
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/sort/StreamSortConfigListener.java:
##########
@@ -62,18 +60,15 @@ public TaskEvent event() {
@Override
public boolean accept(WorkflowContext context) {
ProcessForm processForm = context.getProcessForm();
+ String className = processForm.getClass().getSimpleName();
String groupId = processForm.getInlongGroupId();
- if (!(processForm instanceof GroupResourceProcessForm)) {
- LOGGER.warn("zookeeper enabled was [false] for groupId [{}]", groupId);
+ if (processForm instanceof GroupResourceProcessForm || processForm instanceof StreamResourceProcessForm) {
Review Comment:
Only need to check `StreamResourceProcessForm`, because the following `listen` method casts `ProcessForm` to `StreamResourceProcessForm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org