[GitHub] [gobblin] umustafi commented on a diff in pull request #3771: [GOBBLIN-1907] Handle Lease Completion From Other Multi-active Participants

["umustafi (via GitHub)" <gi...@apache.org>]

umustafi commented on code in PR #3771:
URL: https://github.com/apache/gobblin/pull/3771#discussion_r1325143516


##########
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiterTest.java:
##########
@@ -17,8 +17,10 @@
 
 package org.apache.gobblin.runtime.api;
 
+import com.google.common.base.Optional;

Review Comment:
   The guava optional is actually used throughout the code in `FlowTriggerHandler, GobblinServiceJobScheduler, LeaseArbiter, `test class etc...I'd rather not spend as much time refactoring this right now since a lot of these pieces of code interact with one another so switching between `Java/Guava` optionals will get confusing and I'd need to change it in a lot of places. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org