You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/08/30 08:07:10 UTC
[GitHub] carbondata pull request #2674: [CARBONDATA-2900] Add dynamic configuration f...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2674
[CARBONDATA-2900] Add dynamic configuration for system properties
Following system level properties are added for dynamic configuration. So that user can SET command to set it in JDBC environment like Beeline.
carbon.number.of.cores.while.loading
carbon.number.of.cores.while.compacting
carbon.blockletgroup.size.in.mb
carbon.major.compaction.size
carbon.enable.vector.reader
enable.unsafe.in.query.processing
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
rerun all test
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata add_dynamic_config_load_cores
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2674.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2674
----
commit babc0d496e49f803422cbb84e3f63ca0ed54bab5
Author: Jacky Li <ja...@...>
Date: 2018-08-29T09:36:12Z
add dynamic config
----
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2674
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8178/
---
[GitHub] carbondata pull request #2674: [CARBONDATA-2900] Add dynamic configuration f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2674
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2674
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/107/
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2674
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8247/
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2674
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/176/
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2674
retest this please
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2674
LGTM
---
[GitHub] carbondata issue #2674: [CARBONDATA-2900] Add dynamic configuration for syst...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2674
@jackylk Does these properties need to update in carbondata documents as well?
---