You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/23 16:28:43 UTC
Review Request 47731: GEODE-17: region access needed for destroy
index on a specific region
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47731/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
GEODE-17: region access needed for destroy index on a specific region
When user do "destroy index --region=regionA" it will require DATA:MANAGE:regionA permission,
if he does "destroy index --name=foo" or "destroy index --memberId=memberA", it will require DATA:MANAGE permission
also clean up some tests
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java b863737538bde99e2756ba4e1a1b9a4d93c17b12
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 3ccd71c48db8bb3a64c03d58f8c45ec3339a0a93
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 63bf4473232f955ee67d94e33083867a8fe954a1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java 1a153679e98b7c26652793c60b687f6db398426c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 4b482a97ba401e3e300bfc43587dd6a12ec84295
Diff: https://reviews.apache.org/r/47731/diff/
Testing
-------
security tests
Thanks,
Jinmei Liao
Re: Review Request 47731: GEODE-17: region access needed for destroy
index on a specific region
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47731/#review134791
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On May 23, 2016, 4:28 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47731/
> -----------------------------------------------------------
>
> (Updated May 23, 2016, 4:28 p.m.)
>
>
> Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-17: region access needed for destroy index on a specific region
>
> When user do "destroy index --region=regionA" it will require DATA:MANAGE:regionA permission,
> if he does "destroy index --name=foo" or "destroy index --memberId=memberA", it will require DATA:MANAGE permission
>
> also clean up some tests
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java b863737538bde99e2756ba4e1a1b9a4d93c17b12
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 3ccd71c48db8bb3a64c03d58f8c45ec3339a0a93
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java 63bf4473232f955ee67d94e33083867a8fe954a1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java 1a153679e98b7c26652793c60b687f6db398426c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 4b482a97ba401e3e300bfc43587dd6a12ec84295
>
> Diff: https://reviews.apache.org/r/47731/diff/
>
>
> Testing
> -------
>
> security tests
>
>
> Thanks,
>
> Jinmei Liao
>
>