You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "James Peach (JIRA)" <ji...@apache.org> on 2017/09/27 22:23:00 UTC

[jira] [Assigned] (MESOS-8027) os::open doesn't always atomically apply O_CLOEXEC

     [ https://issues.apache.org/jira/browse/MESOS-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Peach reassigned MESOS-8027:
----------------------------------

    Assignee: James Peach

| [r/62638|https://reviews.apache.org/r/62638] | Removed support for platforms without O_CLOEXEC. |

> os::open doesn't always atomically apply O_CLOEXEC
> --------------------------------------------------
>
>                 Key: MESOS-8027
>                 URL: https://issues.apache.org/jira/browse/MESOS-8027
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: James Peach
>            Assignee: James Peach
>              Labels: security
>
> In [r/39180|https://reviews.apache.org/r/39180], the {{os/open.hpp}} header was refactored so that it conditionally includes {{fcntl.h}}. However {{fcntl.h}} is required to make the {{O_CLOEXEC}} symbol visible, so it is quite likely that {{O_CLOEXEC_UNDEFINED}} will be defined even on systems that do actually support {{O_CLOEXEC}}. This causes {{os::open}} to fall back to the non-atomic open+fcntl sequence, which can leak file descriptors into child processes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)