You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/02/08 19:49:52 UTC
Review Request 65575: Removed redundant comment from the command
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65575/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
Removed redundant comment from the command executor.
Diffs
-----
src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
Diff: https://reviews.apache.org/r/65575/diff/1/
Testing
-------
Not a functional change.
Thanks,
Gaston Kleiman
Re: Review Request 65575: Removed redundant comment from the command
executor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65575/#review197138
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65575]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 9, 2018, 3:49 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65575/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 3:49 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed redundant comment from the command executor.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
>
>
> Diff: https://reviews.apache.org/r/65575/diff/1/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65575: Removed redundant comment from the command
executor.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65575/#review197654
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 8, 2018, 7:49 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65575/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 7:49 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed redundant comment from the command executor.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
>
>
> Diff: https://reviews.apache.org/r/65575/diff/1/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65575: Removed redundant comment from the command
executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65575/#review197109
-----------------------------------------------------------
PASS: Mesos patch 65575 was successfully built and tested.
Reviews applied: `['65575']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65575
- Mesos Reviewbot Windows
On Feb. 8, 2018, 7:49 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65575/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 7:49 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed redundant comment from the command executor.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
>
>
> Diff: https://reviews.apache.org/r/65575/diff/1/
>
>
> Testing
> -------
>
> Not a functional change.
>
>
> Thanks,
>
> Gaston Kleiman
>
>