[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17451#discussion_r125154011
  
    --- Diff: python/pyspark/ml/feature.py ---
    @@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num):
                 word = _convert_to_vector(word)
             return self._call_java("findSynonyms", word, num)
     
    +    @since("2.2.0")
    +    def findSynonymsArray(self, word, num):
    +        """
    +        Find "num" number of words closest in similarity to "word".
    +        word can be a string or vector representation.
    --- End diff --
    
    can you add a test for the vector representation as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org