You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/04/06 09:49:01 UTC
[GitHub] [mesos] andreaspeters commented on a diff in pull request #423: Cleanup: git >= 2.32 does not support gitignore as symlink.
andreaspeters commented on code in PR #423:
URL: https://github.com/apache/mesos/pull/423#discussion_r843735158
##########
support/gitignore:
##########
@@ -39,3 +39,27 @@ CPPLINT.cfg
.deps/
.libs/
*-stamp
+
+.clang-format
+.clang-tidy
+.gitlint
+.pre-commit-config.yaml
+.reviewboardrc
+*/**/Makefile.in
+CPPLINT.cfg
+Makefile.in
+aclocal.m4
+ar-lib
+autom4te.cache/
+build/
+centos7/
+compile
+config.guess
+config.sub
+configure
+*~
Review Comment:
I changed my mind, I think that does not have to be there. With that I want catch tmp files from my editor. But maybe that's to much. :sweat_smile:
##########
support/setup-dev.sh:
##########
@@ -27,7 +27,7 @@ __EOF__
fi
if test ! -e .gitignore; then
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org