[jira] [Commented] (TEZ-2078) Tez UI - Task logs url use in-progress url causing various errors

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316903#comment-14316903 ] 

Hadoop QA commented on TEZ-2078:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12698165/TEZ-2078.2.patch
  against master revision b336ca0.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/172//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/172//console

This message is automatically generated.

> Tez UI - Task logs url use in-progress url causing various errors 
> ------------------------------------------------------------------
>
>                 Key: TEZ-2078
>                 URL: https://issues.apache.org/jira/browse/TEZ-2078
>             Project: Apache Tez
>          Issue Type: Bug
>          Components: UI
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-2078.1.patch, TEZ-2078.2.patch
>
>
> The download link when pointing to the in-progress URL will not work in most cases as the downloaded page is the link to the NM which internally redirects to the job history. This means that the downloaded file will not have any actual log contents. 
> Possible solutions:
>    - only show download button when an application has completed. Please note that this is for when a yarn app has completed. A completed DAG has no guarantee that its logs are available for download. 
>    - download link should always only rely on completed log url and never on in-progress url
>    - view logs link can always point to in-progress url as it will automatically redirect to the jobhistory logs url if the container has completed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)