You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by swgkg <gi...@git.apache.org> on 2014/12/10 08:52:18 UTC
[GitHub] stratos pull request: Update the categary of cartridge as a mandat...
GitHub user swgkg opened a pull request:
https://github.com/apache/stratos/pull/145
Update the categary of cartridge as a mandatory value
This pr will Update the categary of cartridge as a mandatory value
Please review and merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gayangunarathne/stratos 4.1.0-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit 1b3c1cb5d96a386bd82242b6c5d403d223ed1395
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T06:57:17Z
update the categary of cartridge as a mandatory value
commit 7c8da2e8bf28e75e6516264d72d2d2f36ffbe456
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T06:57:55Z
Merge branch '4.1.0-test' of https://github.com/apache/stratos into 4.1.0-test
commit bc9ac98258e0e1d4dc8167f2e1cb6872a1e3b99d
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T07:23:22Z
update the categary of cartridge as a mandatory value
commit ad8742c0f4cd32a75022033ddb6a9940a4b1b77e
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T07:25:38Z
update the categary of cartridge as a mandatory value
commit 38beb6b372c53db874bd79477c00efbcef513c16
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T07:26:32Z
update the categary of cartridge as a mandatory value
commit 8092bffd0fdc29daebb03767ff53a1c6ad9c513d
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-12-10T07:29:08Z
update the categary of cartridge as a mandatory value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update the categary of cartridge as a mandat...
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on the pull request:
https://github.com/apache/stratos/pull/145#issuecomment-66599365
This PR is merged hence closing the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update the categary of cartridge as a mandat...
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg closed the pull request at:
https://github.com/apache/stratos/pull/145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update the categary of cartridge as a mandat...
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on the pull request:
https://github.com/apache/stratos/pull/145#issuecomment-67613970
Thanks Ramith. Yeah StringUtils.isBlank() is more suitable there.
It will cover with PR#157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update the categary of cartridge as a mandat...
Posted by ramith <gi...@git.apache.org>.
Github user ramith commented on a diff in the pull request:
https://github.com/apache/stratos/pull/145#discussion_r22094207
--- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java ---
@@ -108,6 +108,9 @@ public static void createCartridgeDefinition(CartridgeDefinitionBean cartridgeDe
if (cartridgeConfig == null) {
throw new RestAPIException("Populated CartridgeConfig instance is null, cartridge deployment aborted");
}
+ if (cartridgeConfig.getCategory().equals("")|| cartridgeConfig.getCategory().isEmpty()) {
--- End diff --
StringUtils.isBlank() might be useful here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---