You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/16 13:29:05 UTC
[GitHub] [airflow] zhongjiajie opened a new pull request #7736:
[AIRFLOW-7072] Task instance email_alert render only if need
zhongjiajie opened a new pull request #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736
Task instance email_alert render html_content_err template
only if need
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7736: [AIRFLOW-7072] Task
instance email_alert render only if need
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736#issuecomment-599539890
Without add any test cause just move code inside the `Exception`, I should not break the code base
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7736: [AIRFLOW-7072] Task
instance email_alert render only if need
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736#issuecomment-600383875
@potiuk Thanks for merging, if you have time could you please take a look at other PR? https://github.com/apache/airflow/pulls/zhongjiajie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie edited a comment on issue #7736:
[AIRFLOW-7072] Task instance email_alert render only if need
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736#issuecomment-599539890
Without add any test cause just move code inside the `Exception`, It's should not break the code base
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7736: [AIRFLOW-7072] Task
instance email_alert render only if need
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7736: [AIRFLOW-7072] Task
instance email_alert render only if need
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7736: [AIRFLOW-7072] Task instance email_alert render only if need
URL: https://github.com/apache/airflow/pull/7736#issuecomment-600253520
Nice! Thanks @zhongjiajie !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services