You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2025/02/27 16:42:14 UTC
[PR] Remove `api_connexion` [airflow]
vincbeck opened a new pull request, #47158:
URL: https://github.com/apache/airflow/pull/47158
Follow-up of #46942
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2689002863
> @vincbeck Can you also move this PR to the apache/main repo such that I can push some fixes on it? Otherwise you need to make it all yourself from MWAA team :-D
Good idea :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck closed pull request #47158: Remove `api_connexion`
URL: https://github.com/apache/airflow/pull/47158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #47158:
URL: https://github.com/apache/airflow/pull/47158#discussion_r1974253118
##########
airflow/api_connexion/schemas/dag_schema.py:
##########
Review Comment:
Why do we keep this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2689001838
> @vincbeck Can you also move this PR to the apache/main repo such that I can push some fixes on it? Otherwise you need to make it all yourself from MWAA team :-D
As long as I can not push, this diff fixes breeze unit tests:
```
diff --git a/dev/breeze/tests/test_selective_checks.py b/dev/breeze/tests/test_selective_checks.py
index fe79b1bb1b..45e1d27548 100644
--- a/dev/breeze/tests/test_selective_checks.py
+++ b/dev/breeze/tests/test_selective_checks.py
@@ -149,7 +149,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
pytest.param(
("airflow/api/file.py",),
{
- "selected-providers-list-as-string": "amazon common.compat fab",
+ "selected-providers-list-as-string": "amazon common.compat databricks fab",
"all-python-versions": "['3.9']",
"all-python-versions-list-as-string": "3.9",
"python-versions": "['3.9']",
@@ -164,8 +164,8 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
"mypy-docs,mypy-providers,mypy-task-sdk,ts-compile-format-lint-ui",
"upgrade-to-newer-dependencies": "false",
"core-test-types-list-as-string": "API Always",
- "providers-test-types-list-as-string": "Providers[amazon] Providers[common.compat,fab]",
- "individual-providers-test-types-list-as-string": "Providers[amazon] Providers[common.compat] Providers[fab]",
+ "providers-test-types-list-as-string": "Providers[amazon] Providers[common.compat,databricks,fab]",
+ "individual-providers-test-types-list-as-string": "Providers[amazon] Providers[common.compat] Providers[databricks] Providers[fab]",
"testable-core-integrations": "['celery', 'kerberos']",
"testable-providers-integrations": "['cassandra', 'drill', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']",
"needs-mypy": "true",
@@ -314,7 +314,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
"providers/postgres/tests/unit/postgres/file.py",
),
{
- "selected-providers-list-as-string": "amazon common.compat common.sql fab google openlineage "
+ "selected-providers-list-as-string": "amazon common.compat common.sql databricks fab google openlineage "
"pgvector postgres",
"all-python-versions": "['3.9']",
"all-python-versions-list-as-string": "3.9",
@@ -331,9 +331,9 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
"upgrade-to-newer-dependencies": "false",
"core-test-types-list-as-string": "API Always",
"providers-test-types-list-as-string": "Providers[amazon] "
- "Providers[common.compat,common.sql,fab,openlineage,pgvector,postgres] Providers[google]",
+ "Providers[common.compat,common.sql,databricks,fab,openlineage,pgvector,postgres] Providers[google]",
"individual-providers-test-types-list-as-string": "Providers[amazon] Providers[common.compat] Providers[common.sql] "
- "Providers[fab] Providers[google] Providers[openlineage] Providers[pgvector] "
+ "Providers[databricks] Providers[fab] Providers[google] Providers[openlineage] Providers[pgvector] "
"Providers[postgres]",
"needs-mypy": "true",
"mypy-checks": "['mypy-airflow', 'mypy-providers']",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2688805627
Yeah. There is a bit more to it - I tried to do it yesterday, but I realized that this needs a bit more careful removals and in some cases some replacements :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2689024070
> ~Not sure how to do that tho?~
Here we are: https://github.com/apache/airflow/pull/47171
You need to `git branch delete-api_connexion` and `git push --set-upstream upstream delete-api_connexion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2688810387
Most notably. Our `python client` is still built using the old v1.yaml not the new one - so while it is largely compatible, there is this one 422 error I pointed out yesterday even in our test_python_client.py, but also we need to figure out a bit more things:
* the new openapi yaml is auto-generated so we likely need to copy it over in pre-commit
* we thought about changing generator to a newer version (which I think it's an ideal opportunity to do so)
@pierrejeambrun -> is this also your thinking here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #47158:
URL: https://github.com/apache/airflow/pull/47158#discussion_r1974255342
##########
airflow/api_connexion/schemas/dag_schema.py:
##########
Review Comment:
https://github.com/apache/airflow/pull/47158#issuecomment-2688872897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2688872897
It's also used in the [dag commands](https://github.com/apache/airflow/blob/6aaec164baa3122f30296209c2effca6dff466dd/airflow/cli/commands/remote_commands/dag_command.py#L34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2689007133
Not sure how to do that tho?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2690211614
> we thought about changing generator to a newer version (which I think it's an ideal opportunity to do so)
I think updating the breeze release command to use the new `v1-generated.yaml` should do it ?
> we thought about changing generator to a newer version (which I think it's an ideal opportunity to do so)
+100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck closed pull request #47158: Remove `api_connexion`
URL: https://github.com/apache/airflow/pull/47158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2688983442
@vincbeck Can you also move this PR to the apache/main repo such that I can push some fixes on it?
Otherwise you need to make it all yourself from MWAA team :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `api_connexion` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #47158:
URL: https://github.com/apache/airflow/pull/47158#issuecomment-2688894169
> It's also used in the [dag commands](https://github.com/apache/airflow/blob/6aaec164baa3122f30296209c2effca6dff466dd/airflow/cli/commands/remote_commands/dag_command.py#L34).
Yeah for now I kept this file only in `api_connexion`, we can resolve that later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org