You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by lv...@apache.org on 2018/04/25 21:47:50 UTC
[7/7] impala git commit: IMPALA-6800: Add test cases for statements
that require ALTER privilege
IMPALA-6800: Add test cases for statements that require ALTER privilege
Testing:
- Added new test cases
- Ran front-end tests
Change-Id: Ie9fc1249420771ee857259c01acc3f9e7c9ed383
Reviewed-on: http://gerrit.cloudera.org:8080/9905
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/9ecbb184
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/9ecbb184
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/9ecbb184
Branch: refs/heads/2.x
Commit: 9ecbb1846b2cc6d062106f86bb193a34f92536ef
Parents: 22b10ef
Author: Fredy wijaya <fw...@cloudera.com>
Authored: Tue Apr 3 09:43:18 2018 -0700
Committer: Fredy Wijaya <fw...@cloudera.com>
Committed: Wed Apr 25 13:22:15 2018 -0700
----------------------------------------------------------------------
.../java/org/apache/impala/analysis/AuthorizationTest.java | 4 ++++
fe/src/test/java/org/apache/impala/analysis/ParserTest.java | 6 ++++++
2 files changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/9ecbb184/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
index ef6897c..ceb58c3 100644
--- a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
+++ b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
@@ -1642,6 +1642,8 @@ public class AuthorizationTest extends FrontendTestBase {
@Test
public void TestComputeStatsTable() throws ImpalaException {
AuthzOk("compute stats functional_seq_snap.alltypes");
+ // User has ALTER privilege on functional.alltypeserror table.
+ AuthzOk("compute stats functional.alltypeserror");
AuthzError("compute stats functional.alltypes",
"User '%s' does not have privileges to execute 'ALTER' on: functional.alltypes");
@@ -1656,6 +1658,8 @@ public class AuthorizationTest extends FrontendTestBase {
@Test
public void TestDropStats() throws ImpalaException {
AuthzOk("drop stats functional_seq_snap.alltypes");
+ // User has ALTER privilege on functional.alltypeserror table.
+ AuthzOk("drop stats functional.alltypeserror");
AuthzError("drop stats functional.alltypes",
"User '%s' does not have privileges to execute 'ALTER' on: functional.alltypes");
http://git-wip-us.apache.org/repos/asf/impala/blob/9ecbb184/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/analysis/ParserTest.java b/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
index e61266e..3eab55e 100644
--- a/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
+++ b/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
@@ -3586,6 +3586,12 @@ public class ParserTest extends FrontendTestBase {
ParsesOk(String.format("%s CREATE ON SERVER foo %s myRole", formatStr));
ParsesOk(String.format("%s CREATE ON DATABASE foo %s myRole", formatStr));
+ // ALTER privilege.
+ ParsesOk(String.format("%s ALTER ON SERVER %s myRole", formatStr));
+ ParsesOk(String.format("%s ALTER ON SERVER foo %s myRole", formatStr));
+ ParsesOk(String.format("%s ALTER ON DATABASE foo %s myRole", formatStr));
+ ParsesOk(String.format("%s ALTER ON TABLE foo %s myRole", formatStr));
+
// Server scope does not accept a name.
ParsesOk(String.format("%s ALL ON SERVER %s myRole", formatStr));
ParsesOk(String.format("%s INSERT ON SERVER %s myRole", formatStr));