[jira] Commented: (DIRMINA-266) SocketAcceptor.bind() requires address != null and port != 0... why? Also can get to ServerSocketChannel.socket().getLocalSocketAddress()

["Michael Newcomb (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRMINA-266?page=comments#action_12435166 ] 
            
Michael Newcomb commented on DIRMINA-266:
-----------------------------------------

That should be "can't get to ServerSocketChannel.socket().getLocalSocketAddress()" not 'can get to...'


> SocketAcceptor.bind() requires address != null and port != 0... why? Also can get to ServerSocketChannel.socket().getLocalSocketAddress()
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DIRMINA-266
>                 URL: http://issues.apache.org/jira/browse/DIRMINA-266
>             Project: Directory MINA
>          Issue Type: Bug
>    Affects Versions: 0.9.5
>            Reporter: Michael Newcomb
>
> public void bind( SocketAddress address, IoHandler handler, IoServiceConfig config ) throws IOException
> {
>   // if( address == null )
>   // {
>   //     throw new NullPointerException( "address" );
>   // }
>   if( handler == null )
>   {
>       throw new NullPointerException( "handler" );
>   }
>   if( address != null &&  !( address instanceof InetSocketAddress ) )
>   {
>       throw new IllegalArgumentException( "Unexpected address type: " + address.getClass() );
>   }
>   // if( ( ( InetSocketAddress ) address ).getPort() == 0 )
>   // {
>   //     throw new IllegalArgumentException( "Unsupported port number: 0" );
>   // }
>  ...
> Also, you need to fix the physical binding and registration in the channels map:
> // and bind.
> ssc.socket().bind( req.address, cfg.getBacklog() );
> // assign what was actually bound
> //
> req.address = ssc.socket().getLocalSocketAddress();
> ssc.register( selector, SelectionKey.OP_ACCEPT, req );
> I am by no means a networking genius, but is there a reason why this type of use is not allowed?
> Also, if assigning the SocketAddress at bind is used, there needs to be a way for you to get the local socket address from the IoSession api.
> Thanks,
> Michael

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira