You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/01 22:14:48 UTC

[GitHub] [incubator-superset] junlincc edited a comment on pull request #12218: refactor: Enhance control panel Collapse

junlincc edited a comment on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-753393024


   thanks @geido for the PR. if the caret was the only thing that changed, it LGTM. but im not sure why the tabs in the control panel got messed up a bit... 
   <img width="257" alt="Screen Shot 2021-01-01 at 2 10 13 PM" src="https://user-images.githubusercontent.com/67837651/103447054-1d1aa900-4c3b-11eb-8443-9f8b98a44070.png">
   this is what im seeing and how it supposed to look in another open PR
   
   
   <img width="622" alt="Screen Shot 2021-01-01 at 2 11 47 PM" src="https://user-images.githubusercontent.com/67837651/103447104-9b774b00-4c3b-11eb-8bd0-3813d074781f.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org