You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 19:20:56 UTC

[GitHub] [airflow] ashb commented on a change in pull request #12856: Mark required fields in Forms as required

ashb commented on a change in pull request #12856:
URL: https://github.com/apache/airflow/pull/12856#discussion_r537105288



##########
File path: airflow/www/forms.py
##########
@@ -194,9 +201,12 @@ class TaskInstanceEditForm(DynamicForm):
             ('up_for_retry', 'up_for_retry'),
         ),
         widget=Select2Widget(),
+        validators=[InputRequired()],
     )
     execution_date = DateTimeWithTimezoneField(
-        lazy_gettext('Execution Date'), widget=AirflowDateTimePickerROWidget()
+        lazy_gettext('Execution Date'),
+        widget=AirflowDateTimePickerROWidget(),
+        validators=[InputRequired()],

Review comment:
       I guess it's optional, but this means there's a nice red `*` so it's consistent.
   
   In short: no harm, could leave or remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org