You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "Fabian Christ (Created) (JIRA)" <ji...@apache.org> on 2012/02/14 08:06:59 UTC

[jira] [Created] (STANBOL-490) IndexedGraphTest takes too much time

IndexedGraphTest takes too much time
------------------------------------

                 Key: STANBOL-490
                 URL: https://issues.apache.org/jira/browse/STANBOL-490
             Project: Stanbol
          Issue Type: Improvement
          Components: Commons
            Reporter: Fabian Christ
            Assignee: Rupert Westenthaler


The test org.apache.stanbol.commons.indexedgraph.IndexedGraphTest takes too much time (1062ms on my machine). This is in conflict with the goal that unit tests should be fast to keep the build process efficient for developers, It seems that this is more a performance than a unit test.

This test should be moved to the integration tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (STANBOL-490) IndexedGraphTest takes too much time

Posted by "Rupert Westenthaler (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/STANBOL-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rupert Westenthaler resolved STANBOL-490.
-----------------------------------------

    Resolution: Fixed

after revision #1293241 the test only uses 100 instead of 1000 iterations.
                
> IndexedGraphTest takes too much time
> ------------------------------------
>
>                 Key: STANBOL-490
>                 URL: https://issues.apache.org/jira/browse/STANBOL-490
>             Project: Stanbol
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Fabian Christ
>            Assignee: Rupert Westenthaler
>              Labels: Performance, Test
>
> The test org.apache.stanbol.commons.indexedgraph.IndexedGraphTest takes too much time (1062ms on my machine). This is in conflict with the goal that unit tests should be fast to keep the build process efficient for developers, It seems that this is more a performance than a unit test.
> This test should be moved to the integration tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (STANBOL-490) IndexedGraphTest takes too much time

Posted by "Rupert Westenthaler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/STANBOL-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207626#comment-13207626 ] 

Rupert Westenthaler commented on STANBOL-490:
---------------------------------------------

Hi Fabian

This is related to the "testPerformance" unit test. I had already considered to deactivate this test because performance testing is not important to be done during unit test. However this test does also very nicely validate that the the filtered iterators returned by the IndexedGraph implementation return the same triples as the SimpleMGraph implementation used as a reference.

Such tests are also included in the default test set provided by Clerezza, but in this case they are performed on a very small set of triples and therefore may parse by accident. This tests uses currently a Graph with 100k triples and a randomly generated set of iterations what makes it very unlikely to miss issues in the implementation of the Comparators used for the internal indexes.

Because of that I suggest that you adapt the following parameters of the "testPerformance" until you reach an acceptable execution time:

        int iterations = 1000;
        int graphsize = 100000;
        [..]
        TestCase testCase = new TestCase(sg, 100, 5, 100);

You can safely change all parameters. However I would not reduce the third parameter ('5') to TestCase.

best
Rupert

                
> IndexedGraphTest takes too much time
> ------------------------------------
>
>                 Key: STANBOL-490
>                 URL: https://issues.apache.org/jira/browse/STANBOL-490
>             Project: Stanbol
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Fabian Christ
>            Assignee: Rupert Westenthaler
>              Labels: Performance, Test
>
> The test org.apache.stanbol.commons.indexedgraph.IndexedGraphTest takes too much time (1062ms on my machine). This is in conflict with the goal that unit tests should be fast to keep the build process efficient for developers, It seems that this is more a performance than a unit test.
> This test should be moved to the integration tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira