You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@crail.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/07 14:30:00 UTC

[jira] [Commented] (CRAIL-19) Check code style on build

    [ https://issues.apache.org/jira/browse/CRAIL-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607179#comment-16607179 ] 

ASF GitHub Bot commented on CRAIL-19:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-crail/pull/13


> Check code style on build
> -------------------------
>
>                 Key: CRAIL-19
>                 URL: https://issues.apache.org/jira/browse/CRAIL-19
>             Project: Apache Crail
>          Issue Type: Improvement
>            Reporter: Jonas Pfefferle
>            Priority: Major
>
> Style check the code on compile and fail compilation if there are violations.
> I propose using the google java code style guide, which is already pretty close to what we are having now (e.g. does not allow no braces on if/else etc). Spark also uses a modified version of the google code style.
> [https://google.github.io/styleguide/javaguide.html]
> [https://github.com/apache/spark/blob/master/dev/checkstyle.xml]
> Supported by many formatters, IDEs, etc like Intellij, clang-format, Eclipse:
> https://github.com/google/styleguide



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)