You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/03 08:37:25 UTC

[GitHub] [iotdb] samperson1997 commented on a change in pull request #3220: jdbc - get col type bug

samperson1997 commented on a change in pull request #3220:
URL: https://github.com/apache/iotdb/pull/3220#discussion_r644600340



##########
File path: session/src/test/java/org/apache/iotdb/session/IoTDBSessionSimpleIT.java
##########
@@ -665,7 +665,7 @@ private void checkResult(Session session)
           "root.sg.d1.s2"
         });
     Assert.assertArrayEquals(
-        dataSet.getColumnTypes().toArray(new TSDataType[0]),
+        dataSet.getColumnTypes().toArray(new String[0]),
         new TSDataType[] {
           TSDataType.INT64,
           TSDataType.INT64,

Review comment:
       Hi, I wonder whether this change is correct, since the class is `TSDataType` and `String` separately.
   I got this failure when I run tests in `IoTDBSessionSimpleIT.java`:
   ![20431622707611_ pic](https://user-images.githubusercontent.com/19167280/120614520-e7981700-c489-11eb-89ed-11b61a552912.jpg)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org