You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/24 21:13:00 UTC

[GitHub] [hudi] prashantwason opened a new pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

prashantwason opened a new pull request #2026:
URL: https://github.com/apache/hudi/pull/2026


   ## *Tips*
   ## What is the purpose of the pull request
   
   Make timeline server timeout settings configurable.
   
   ## Brief change log
   
   Add timeout config settings for timeline server.
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   This pull request is already covered by existing tests.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] n3nash commented on a change in pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #2026:
URL: https://github.com/apache/hudi/pull/2026#discussion_r475920074



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
##########
@@ -52,7 +54,7 @@
   public static final String DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "false";
   public static final String DEFUALT_REMOTE_VIEW_SERVER_HOST = "localhost";
   public static final Integer DEFAULT_REMOTE_VIEW_SERVER_PORT = 26754;
-
+  public static final Integer DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS = 300 * 60; // 5 min

Review comment:
       @prashantwason How is this 5 mins ? If it's secs, it should just be 300 ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] prashantwason commented on a change in pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

Posted by GitBox <gi...@apache.org>.
prashantwason commented on a change in pull request #2026:
URL: https://github.com/apache/hudi/pull/2026#discussion_r475932300



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java
##########
@@ -147,7 +153,7 @@ public RemoteHoodieTableFileSystemView(String server, int port, HoodieTableMetaC
     String url = builder.toString();
     LOG.info("Sending request : (" + url + ")");
     Response response;
-    int timeout = 1000 * 300; // 5 min timeout
+    int timeout = this.timeoutSecs * 1000; // msec

Review comment:
       Yes, msec.

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
##########
@@ -52,7 +54,7 @@
   public static final String DEFAULT_FILESYSTEM_VIEW_INCREMENTAL_SYNC_MODE = "false";
   public static final String DEFUALT_REMOTE_VIEW_SERVER_HOST = "localhost";
   public static final Integer DEFAULT_REMOTE_VIEW_SERVER_PORT = 26754;
-
+  public static final Integer DEFAULT_REMOTE_TIMELINE_CLIENT_TIMEOUT_SECS = 300 * 60; // 5 min

Review comment:
       Corrected.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] prashantwason commented on pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

Posted by GitBox <gi...@apache.org>.
prashantwason commented on pull request #2026:
URL: https://github.com/apache/hudi/pull/2026#issuecomment-679401505


   @n3nash corrected the errors.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] n3nash merged pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

Posted by GitBox <gi...@apache.org>.
n3nash merged pull request #2026:
URL: https://github.com/apache/hudi/pull/2026


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] n3nash commented on a change in pull request #2026: [HUDI-1135] Make timeline server timeout settings configurable.

Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #2026:
URL: https://github.com/apache/hudi/pull/2026#discussion_r475920521



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java
##########
@@ -147,7 +153,7 @@ public RemoteHoodieTableFileSystemView(String server, int port, HoodieTableMetaC
     String url = builder.toString();
     LOG.info("Sending request : (" + url + ")");
     Response response;
-    int timeout = 1000 * 300; // 5 min timeout
+    int timeout = this.timeoutSecs * 1000; // msec

Review comment:
       Does the Request.connect expect timeout in millisecs ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org