You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "necouchman (via GitHub)" <gi...@apache.org> on 2024/02/25 23:01:09 UTC
[PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
necouchman opened a new pull request, #494:
URL: https://github.com/apache/guacamole-server/pull/494
After the changes in #484, the version of libguac needs to be bumped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner merged PR #494:
URL: https://github.com/apache/guacamole-server/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #494:
URL: https://github.com/apache/guacamole-server/pull/494#discussion_r1518293792
##########
src/libguac/Makefile.am:
##########
@@ -160,7 +160,7 @@ libguac_la_CFLAGS = \
-Werror -Wall -pedantic
libguac_la_LDFLAGS = \
- -version-info 23:0:0 \
+ -version-info 24:0:0 \
Review Comment:
Never mind - I think you were right to update to `24:0:0`. In the case of 1.5.5, the only change I see to any interface is the additional `socket_lock` member added to `guac_socket_ssl_data`, and that does qualify as a "changed interface".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #494:
URL: https://github.com/apache/guacamole-server/pull/494#discussion_r1518175917
##########
src/libguac/Makefile.am:
##########
@@ -160,7 +160,7 @@ libguac_la_CFLAGS = \
-Werror -Wall -pedantic
libguac_la_LDFLAGS = \
- -version-info 23:0:0 \
+ -version-info 24:0:0 \
Review Comment:
I'm late to the party here, but are the changes between 1.5.4 and 1.5.5 ABI-breaking?
If not, I think this should be `24:0:1` (interfaces added, not changed or removed). Doing a quick diff between `1.5.4` and `staging/1.5.5`, I'm not seeing anything stand out as breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #494:
URL: https://github.com/apache/guacamole-server/pull/494#discussion_r1518175917
##########
src/libguac/Makefile.am:
##########
@@ -160,7 +160,7 @@ libguac_la_CFLAGS = \
-Werror -Wall -pedantic
libguac_la_LDFLAGS = \
- -version-info 23:0:0 \
+ -version-info 24:0:0 \
Review Comment:
I'm late to the party here, but are the changes between 1.5.4 and 1.5.5 API-breaking?
If not, I think this should be `24:0:1` (interfaces added, not changed or removed). Doing a quick diff between `1.5.4` and `staging/1.5.5`, I'm not seeing anything stand out as breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1906: Bump soversion for liguac after API changes. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #494:
URL: https://github.com/apache/guacamole-server/pull/494#discussion_r1518212583
##########
src/libguac/Makefile.am:
##########
@@ -160,7 +160,7 @@ libguac_la_CFLAGS = \
-Werror -Wall -pedantic
libguac_la_LDFLAGS = \
- -version-info 23:0:0 \
+ -version-info 24:0:0 \
Review Comment:
Nah, this was probably my bad, here - I was trying to figure out the right one to do.
Also, do you mean `24:0:1` or `23:0:1`?
I can open a new PR to fix it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org