You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Mulder (Code Review)" <ge...@cloudera.org> on 2017/09/29 19:44:48 UTC

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

Matthew Mulder has uploaded this change for review. ( http://gerrit.cloudera.org:8080/5813


Change subject: Add tpcds-unmodified performance workload.
......................................................................

Add tpcds-unmodified performance workload.

Add Mostafa's tpcds-unmodified performance workload for use in the
performance test runs. This workload includes 97 queries.

Mostafa writes:
    Before Impala 2.5 we didn't have Runtimefilters, which made TPC-DS
    queries run very slow, so we ran queries that have explicit partition
    filters to workaround the limitation.
    Queries under "tpcds" has those explicit filters, post Impala 2.5 I
    added the un-modified version of the workload to have more coverage.

    Q24 and Q67 aren't added because the unmodified version of the query is
    not supported by Impala and the rewrite version takes a very long time
    to complete.

This workload has already been running nightly for many months
out of Mostafa's private branch. This checkin simply does a little
cleanup to prepare it for commit to the public repo.

How It Was Tested
-----------------
impala-python -u bin/run-workload.py --client_type=beeswax
--workloads=tpcds-unmodified:_1000 --query_iterations 1
--workload_iterations 1
--exec_options='sync_ddl:1;num_scanner_threads:12;MAX_NUM_RUNTIME_FILTERS:50'
--impalads=<impalad_host>:21000 --num_clients=1
--table_formats=parquet/none --query_names='.*'
--results_json_file=/tmp/benchmark_results.json

Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
---
A testdata/workloads/tpcds-unmodified/queries/tpcds-q1.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q10.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q11.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q12.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q13.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q14.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q15.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q16.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q17.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q18.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q19.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q2.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q20.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q21.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q22.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q23.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q25.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q26.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q27.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q28.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q29.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q3.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q30.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q32.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q33.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q34.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q35.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q36.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q37.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q38.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q39.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q4.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q40.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q41.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q42.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q43.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q44.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q45.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q46.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q47.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q48.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q49.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q5.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q50.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q51.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q52.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q53.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q54.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q55.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q56.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q57.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q58.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q6.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q60.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q61.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q62.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q63.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q64.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q65.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q66.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q68.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q69.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q7.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q70.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q71.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q72.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q73.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q74.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q75.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q76.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q77.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q78.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q79.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q8.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q80.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q81.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q82.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q83.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q84.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q85.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q86.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q87.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q88.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q89.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q9.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q90.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q91.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q92.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q93.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q94.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q95.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q96.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q97.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q98.test
A testdata/workloads/tpcds-unmodified/queries/tpcds-q99.test
A testdata/workloads/tpcds-unmodified/tpcds-unmodified_core.csv
A testdata/workloads/tpcds-unmodified/tpcds-unmodified_dimensions.csv
A testdata/workloads/tpcds-unmodified/tpcds-unmodified_exhaustive.csv
A testdata/workloads/tpcds-unmodified/tpcds-unmodified_pairwise.csv
101 files changed, 5,297 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/5813/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
Gerrit-Change-Number: 5813
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/5813 )

Change subject: Add tpcds-unmodified performance workload.
......................................................................


Patch Set 1:

This has been sitting idle for a long time - should we abandon it?


-- 
To view, visit http://gerrit.cloudera.org:8080/5813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
Gerrit-Change-Number: 5813
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Apr 2018 22:47:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/5813 )

Change subject: Add tpcds-unmodified performance workload.
......................................................................


Abandoned

Let's just abandon until the new version is ready for review. We can still look at the abandoned patch but it won't show in any lists of patches that need to be reviewed.
-- 
To view, visit http://gerrit.cloudera.org:8080/5813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
Gerrit-Change-Number: 5813
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/5813 )

Change subject: Add tpcds-unmodified performance workload.
......................................................................


Patch Set 1:

Nithya is working on on this now.


-- 
To view, visit http://gerrit.cloudera.org:8080/5813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
Gerrit-Change-Number: 5813
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Apr 2018 17:52:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/5813 )

Change subject: Add tpcds-unmodified performance workload.
......................................................................


Patch Set 1:

Though I suspect this will be abanadoned, and a new patch submitted.


-- 
To view, visit http://gerrit.cloudera.org:8080/5813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea8f3b4e20a30553f1a5a321b2053ff9ca967e92
Gerrit-Change-Number: 5813
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Apr 2018 17:53:28 +0000
Gerrit-HasComments: No