You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2008/07/10 01:17:31 UTC
[jira] Created: (ODE-328) PartnerRoleMessageExchange#replyWithFault
must receive fault name
PartnerRoleMessageExchange#replyWithFault must receive fault name
-----------------------------------------------------------------
Key: ODE-328
URL: https://issues.apache.org/jira/browse/ODE-328
Project: ODE
Issue Type: Bug
Components: BPEL Runtime
Affects Versions: 1.2, 1.1.1
Reporter: Alexis Midon
Priority: Critical
Fix For: 1.3
org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
See org.apache.ode.bpel.runtime.INVOKE, line 168.
Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-328) PartnerRoleMessageExchange#replyWithFault
must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon updated ODE-328:
-----------------------------
Assignee: Alexis Midon
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Assignee: Alexis Midon
> Priority: Critical
> Fix For: 1.2, 1.3
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612685#action_12612685 ]
Alexis Midon commented on ODE-328:
----------------------------------
Fix commited for trunk and branch:
replyWithFault must receive faultName, not faultType no matter what the method signature says
Step 2 would be to get ride of this dirty trick an refactor APIs so that fault type is not mentionned anymore
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.2
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ODE-328) PartnerRoleMessageExchange#replyWithFault
must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon closed ODE-328.
----------------------------
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Assignee: Alexis Midon
> Priority: Critical
> Fix For: 1.3.1
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-328) PartnerRoleMessageExchange#replyWithFault
must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon updated ODE-328:
-----------------------------
Affects Version/s: (was: 1.1.1)
(was: 1.2)
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.2
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon resolved ODE-328.
------------------------------
Resolution: Fixed
Fix Version/s: 1.3
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.3, 1.2
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon reopened ODE-328:
------------------------------
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.2, 1.3
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612612#action_12612612 ]
alexismidon edited comment on ODE-328 at 7/10/08 12:46 PM:
------------------------------------------------------------
This issue has remained dormant so far because in all test cases fault message and fault type are the same.
To reproduce the issue:
1. edit these 2 files:
axis2-war/src/test/resources/TestStructuredFault/HelloWorld2.bpel
axis2-war/src/test/resources/TestStructuredFault/dummy-service.wsdl
2. rename the DummyException message into DummyExceptionMessage
org.apache.ode.axis2.ServiceFaultCatchTest should now fail.
was (Author: alexismidon):
This issue has remained dormant so far because in all test cases fault message and fault type are the same.
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Affects Versions: 1.1.1, 1.2
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.3
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-328) PartnerRoleMessageExchange#replyWithFault
must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon updated ODE-328:
-----------------------------
Comment: was deleted
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.2
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon resolved ODE-328.
------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 1.3)
1.2
A proper fix for this bug would imply to rename the BPEL_MESSAGE_EXCHANGE.FAULT_TYPE into BPEL_MESSAGE_EXCHANGE.FAULT_NAME to make the data model in line.
This change is not harmless and may have side-effects, the workaround (fault type and fault name must the same) will do for 1.2.
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Affects Versions: 1.1.1, 1.2
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.2
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-328)
PartnerRoleMessageExchange#replyWithFault must receive fault name
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612612#action_12612612 ]
Alexis Midon commented on ODE-328:
----------------------------------
This issue has remained dormant so far because in all test cases fault message and fault type are the same.
> PartnerRoleMessageExchange#replyWithFault must receive fault name
> -----------------------------------------------------------------
>
> Key: ODE-328
> URL: https://issues.apache.org/jira/browse/ODE-328
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Affects Versions: 1.1.1, 1.2
> Reporter: Alexis Midon
> Priority: Critical
> Fix For: 1.3
>
>
> org.apache.ode.bpel.iapi.PartnerRoleMessageExchange#replyWithFault(QName faultType, Message outputFaultMessage)
> The faultType is actually used as the fault name. If you actually pass the fault type, fault management will fail because FaultData#_faultName is a the fault type.
> See org.apache.ode.bpel.runtime.INVOKE, line 168.
> Fault Management has been working fine so far because this bug is masked by another one: SoapExternalService already provides the fault name instead of the fault type.
> See org.apache.ode.axis2.soapbinding.SoapMessageConverter#parseSoapFault
> The fix is to change replyWithFault signature to accept the fault name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.