[jira] [Commented] (FELIX-4196) If proxy or SSL Offloader already sends https urls the SSLFilter wil created a httpss URL

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743606#comment-13743606 ] 

Felix Meschberger commented on FELIX-4196:
------------------------------------------

Thanks for reporting. But, I do not completely understand the issue:

> A replace of "http://" to "https://" will be less buggy. 

I do not see how ? The code

  String tmp = "https".concat(super.getRequestURL().substring(4));

sounds exactly the same, right ?

The only way to make this less buggy would be to first check whether the URL startsWidth("http://").

Or am I completely on the wrong track ?
                
> If proxy or SSL Offloader already sends https urls the SSLFilter wil created a httpss URL
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-4196
>                 URL: https://issues.apache.org/jira/browse/FELIX-4196
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-sslfilter-1.0.0
>            Reporter: Kris Barnhoorn
>
> Hi,
> If proxy or SSL Offloader already sends https urls the SSLFilter wil created a httpss URL
> See code in https://fisheye6.atlassian.com/browse/felix/trunk/http/sslfilter/src/main/java/org/apache/felix/http/sslfilter/internal/SslFilterRequest.java?r=1394715
> {code}
>    public StringBuffer getRequestURL()
>    {
>        if (this.requestURL == null) {
>            // insert an 's' after the http scheme
>            StringBuffer tmp = super.getRequestURL();
>            tmp.insert(4, 's');
>            this.requestURL = tmp.toString();
>        }
>  
>        return new StringBuffer(this.requestURL);
>    }
> {code}
> A replace of "http://" to "https://" will be less buggy.
> Furthermore an option to not rewrite from http to https would be good as in some cases this is not desirable.
> Kind regards,
> Kris.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira