You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@otava.apache.org by "sarthaksin1857 (via GitHub)" <gi...@apache.org> on 2026/02/22 19:02:33 UTC

[PR] Fix Graphite Tag integration [otava]

sarthaksin1857 opened a new pull request, #131:
URL: https://github.com/apache/otava/pull/131

   https://github.com/apache/otava/issues/24
   
   ## What
   - Change example image to alpine and install bash/curl (datagen was not working when curl was uncommented)
   - Make all fields optional with default values in GraphiteEvent
   
   
   ## Proof it works
   Now we see 
   ```
   time                       run    branch       version    commit      throughput    response_time    cpu_usage
   -------------------------  -----  -----------  ---------  --------  ------------  ---------------  -----------
   2026-02-22 18:51:10 +0000  null   new-feature  0.0.1      p7q8r9           61160               87          0.2
   2026-02-22 18:52:10 +0000  null   new-feature  0.0.1      m4n5o6           60160               85          0.3
   2026-02-22 18:53:10 +0000  null   new-feature  0.0.1      j1k2l3           60960               89          0.1
                                                                       ············                   ···········  
                                                                              -5.6%                       +300.0%  
                                                                       ············                   ···········  
   2026-02-22 18:54:10 +0000  null   new-feature  0.0.1      g7h8i9           57123               88          0.8
   2026-02-22 18:55:10 +0000  null   new-feature  0.0.1      d4e5f6           57980               87          0.9
   2026-02-22 18:56:10 +0000  null   new-feature  0.0.1      a1b2c3           56950               85          0.7
   ```
   
   Which makes sense as we do not set `run` but we do set everything else


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r2838397654


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
-    pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":
-            self.branch = None
+    test_owner: Optional[str] = "null"
+    test_name: Optional[str] = "null"
+    run_id: Optional[str] = "null"
+    status: Optional[str] = "null"
+    start_time: Optional[datetime] = None
+    pub_time: Optional[datetime] = None
+    end_time: Optional[datetime] = None
+    version: Optional[str] = "null"
+    branch: Optional[str] = "null"
+    commit: Optional[str] = "null"
+
+
+    def __post_init__(self):
+        # Ensure pub_time is always a datetime
+        if self.pub_time is None:
+            self.pub_time = datetime.now()
         else:
-            self.branch = branch
-        if len(commit) == 0 or commit == "null":
-            self.commit = None
-        else:
-            self.commit = commit
+            self.pub_time = parse_datetime(str(self.pub_time))
+
+        # Now safely parse start_time and end_time
+        self.start_time = parse_datetime(str(self.start_time)) if self.start_time else self.pub_time
+        self.end_time = parse_datetime(str(self.end_time)) if self.end_time else self.pub_time

Review Comment:
   Still deciding if start and end time need to be set



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r3105345385


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":
-            self.branch = None
-        else:
-            self.branch = branch
-        if len(commit) == 0 or commit == "null":
-            self.commit = None
-        else:
-            self.commit = commit
+    test_owner: Optional[str] = None
+    test_name: Optional[str] = None
+    run_id: Optional[str] = None
+    status: Optional[str] = None
+    start_time: Optional[datetime] = None
+    end_time: Optional[datetime] = None
+    version: Optional[str] = None
+    branch: Optional[str] = None
+    commit: Optional[str] = None
+
+
+    def __post_init__(self):
+        if self.pub_time is None:
+            raise ValueError("pub_time is required and cannot be None")
+        # Ensure pub_time is always a datetime
+
+        # Only parse if it isn't already a datetime object
+        if isinstance(self.pub_time, str):
+            self.pub_time = parse_datetime(self.pub_time)
+        elif isinstance(self.pub_time, (int, float)):
+            self.pub_time = datetime.fromtimestamp(self.pub_time)

Review Comment:
   This was more just me looking at this code an how to future proof it. 
   
   The function says that pub_time is already a date time  and if its already a datetime, why try to parse it again? 
   
   Similarly if someone passes in a unix int like 1776522767 the string function wont work either
   
   So before we passed in an integer string as "datetime" and then parsed it back into a string, and then into the proper object. 
   
   
   I will just move the logic into parse_datetime and make this code cleaner
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r3278530511


##########
otava/util.py:
##########
@@ -134,18 +134,47 @@ class DateFormatError(ValueError):
     message: str
 
 
-def parse_datetime(date: Optional[str]) -> Optional[datetime]:
+def parse_datetime(date: Optional[Union[str, int, float, datetime]]) -> Optional[datetime]:
     """
-    Converts a human-readable string into a datetime object.
-    Accepts many formats and many languages, see dateparser package.
-    Raises DataFormatError if the input string format hasn't been recognized.
+    Normalize various datetime inputs into a timezone-aware datetime.
+
+    Supports:
+    - datetime (returned as-is)
+    - int/float (treated as Unix timestamp)
+    - str (parsed via dateparser)
+    - None (returns None)
     """
     if date is None:
         return None
-    parsed: datetime = dateparser.parse(date, settings={"RETURN_AS_TIMEZONE_AWARE": True})
-    if parsed is None:
-        raise DateFormatError(f"Invalid datetime value: {date}")
-    return parsed
+
+    if isinstance(date, datetime):
+        return date
+
+    if isinstance(date, (int, float)):
+        return datetime.fromtimestamp(date, tz=timezone.utc)
+
+    if isinstance(date, str):
+        parsed = dateparser.parse(date, settings={"RETURN_AS_TIMEZONE_AWARE": True})
+        if parsed is None:
+            raise DateFormatError(f"Invalid datetime value: {date}")
+        return parsed
+
+    raise TypeError(f"Unsupported type for datetime parsing: {type(date)}")
+
+
+def clean_str(value: Optional[str]) -> Optional[str]:
+    if value is None:
+        return None
+
+    if not isinstance(value, str):
+        return value  # or raise TypeError if you want strictness

Review Comment:
   This return violates the type signature. I'd throw a type error.



##########
otava/graphite.py:
##########
@@ -80,49 +79,32 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
+    test_owner: Optional[str] = None
+    test_name: Optional[str] = None
+    run_id: Optional[str] = None
+    status: Optional[str] = None
+    start_time: Optional[datetime] = None
+    end_time: Optional[datetime] = None
+    version: Optional[str] = None
+    branch: Optional[str] = None
+    commit: Optional[str] = None
 
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":
-            self.branch = None
-        else:
-            self.branch = branch
-        if len(commit) == 0 or commit == "null":
-            self.commit = None
-        else:
-            self.commit = commit
+
+    def __post_init__(self):
+        if self.pub_time is None:
+            raise ValueError("pub_time is required and cannot be None")
+        # Ensure pub_time is always a datetime
+        self.pub_time = parse_datetime(str(self.pub_time))

Review Comment:
   I think we should do `parse_datetime` on `start_time` and `date_time`. If they are `None`, they will remain `None`. If they are strings/ints, they will get converted to `datetime`. Without this change, we may get arbitrary types in those fields. Example:
   
   ```python
   def test_graphite_event_parses_start_and_end_time():
       """start_time and end_time are documented as supported tags and annotated
       Optional[datetime]; if Graphite delivers them as Unix timestamps (int) or
       ISO strings in the event data, they must be normalized to tz-aware
       datetimes, the same way pub_time is."""
       event = GraphiteEvent(
           pub_time=1700000000,
           start_time=1700000000,
           end_time="2024-01-01 10:00:00",
       )
   
       assert isinstance(event.start_time, datetime)
       assert event.start_time.tzinfo is not None
   
       assert isinstance(event.end_time, datetime)
       assert event.end_time.tzinfo is not None
   ```



##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(

Review Comment:
   This is fixed now, thanks!



##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],

Review Comment:
   I like this idea! Again, it is not required in this PR, but is worth doing in a follow-up.



##########
otava/util.py:
##########
@@ -134,18 +134,47 @@ class DateFormatError(ValueError):
     message: str
 
 
-def parse_datetime(date: Optional[str]) -> Optional[datetime]:
+def parse_datetime(date: Optional[Union[str, int, float, datetime]]) -> Optional[datetime]:
     """
-    Converts a human-readable string into a datetime object.
-    Accepts many formats and many languages, see dateparser package.
-    Raises DataFormatError if the input string format hasn't been recognized.
+    Normalize various datetime inputs into a timezone-aware datetime.
+
+    Supports:
+    - datetime (returned as-is)
+    - int/float (treated as Unix timestamp)
+    - str (parsed via dateparser)
+    - None (returns None)
     """
     if date is None:
         return None
-    parsed: datetime = dateparser.parse(date, settings={"RETURN_AS_TIMEZONE_AWARE": True})
-    if parsed is None:
-        raise DateFormatError(f"Invalid datetime value: {date}")
-    return parsed
+
+    if isinstance(date, datetime):
+        return date
+
+    if isinstance(date, (int, float)):
+        return datetime.fromtimestamp(date, tz=timezone.utc)
+
+    if isinstance(date, str):

Review Comment:
   This method supports strings, ints, floats, datetime now. However, all its callers are using `str(input)`, so there are no callers at all that benefit from this change.
   
   While I am not asking to refactor callers of this method across the entire codebase, do you think it would make sense to use it in Graphite importer? If not... then what's the point of this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r2838397654


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
-    pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":
-            self.branch = None
+    test_owner: Optional[str] = "null"
+    test_name: Optional[str] = "null"
+    run_id: Optional[str] = "null"
+    status: Optional[str] = "null"
+    start_time: Optional[datetime] = None
+    pub_time: Optional[datetime] = None
+    end_time: Optional[datetime] = None
+    version: Optional[str] = "null"
+    branch: Optional[str] = "null"
+    commit: Optional[str] = "null"
+
+
+    def __post_init__(self):
+        # Ensure pub_time is always a datetime
+        if self.pub_time is None:
+            self.pub_time = datetime.now()
         else:
-            self.branch = branch
-        if len(commit) == 0 or commit == "null":
-            self.commit = None
-        else:
-            self.commit = commit
+            self.pub_time = parse_datetime(str(self.pub_time))
+
+        # Now safely parse start_time and end_time
+        self.start_time = parse_datetime(str(self.start_time)) if self.start_time else self.pub_time
+        self.end_time = parse_datetime(str(self.end_time)) if self.end_time else self.pub_time

Review Comment:
   Still deciding if start and end time need to be set. The api only return a single timestamp (publish time) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r3105437742


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],

Review Comment:
   Yea I wonder if we should even define fields here as "supported tags" and rather just store them in a map and print them all at the end as columns 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on PR #131:
URL: https://github.com/apache/otava/pull/131#issuecomment-3948954299

   @Gerrrr Can you take a look here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r3105419684


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":

Review Comment:
   Since I switched all actual "optional" fields to be optional, I will clean all of them (except pub_time)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r2838397654


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
-    pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(
-        self,
-        pub_time: int,
-        test_owner: str,
-        test_name: str,
-        run_id: str,
-        status: str,
-        start_time: int,
-        end_time: int,
-        version: Optional[str],
-        branch: Optional[str],
-        commit: Optional[str],
-    ):
-        self.test_owner = test_owner
-        self.test_name = test_name
-        self.run_id = run_id
-        self.status = status
-        self.start_time = parse_datetime(str(start_time))
-        self.pub_time = parse_datetime(str(pub_time))
-        self.end_time = parse_datetime(str(end_time))
-        if len(version) == 0 or version == "null":
-            self.version = None
-        else:
-            self.version = version
-        if len(branch) == 0 or branch == "null":
-            self.branch = None
+    test_owner: Optional[str] = "null"
+    test_name: Optional[str] = "null"
+    run_id: Optional[str] = "null"
+    status: Optional[str] = "null"
+    start_time: Optional[datetime] = None
+    pub_time: Optional[datetime] = None
+    end_time: Optional[datetime] = None
+    version: Optional[str] = "null"
+    branch: Optional[str] = "null"
+    commit: Optional[str] = "null"
+
+
+    def __post_init__(self):
+        # Ensure pub_time is always a datetime
+        if self.pub_time is None:
+            self.pub_time = datetime.now()
         else:
-            self.branch = branch
-        if len(commit) == 0 or commit == "null":
-            self.commit = None
-        else:
-            self.commit = commit
+            self.pub_time = parse_datetime(str(self.pub_time))
+
+        # Now safely parse start_time and end_time
+        self.start_time = parse_datetime(str(self.start_time)) if self.start_time else self.pub_time
+        self.end_time = parse_datetime(str(self.end_time)) if self.end_time else self.pub_time

Review Comment:
   Still deciding if start and end time need to be set. The api only return a single timestamp (publish time) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on PR #131:
URL: https://github.com/apache/otava/pull/131#issuecomment-4274066073

   @Gerrrr sorry for the wait this is ready for another pass. 
   
   I made it so 
   
   - All optional fields are cleaned
   - the parse_datetime utility handles string, int, long, and datetime inputs 
   - Updated the documentation
   - Added a few tests
   
   I tried to extend the integration tests but it didn't seem to play well with tags. Whenever I tried sending an event, it would time out (I can file an issue for adding integration coverage and tackle that next?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Graphite Tag integration [otava]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #131:
URL: https://github.com/apache/otava/pull/131#discussion_r3105445395


##########
otava/graphite.py:
##########
@@ -80,49 +79,28 @@ class GraphiteError(IOError):
 
 @dataclass
 class GraphiteEvent:
-    test_owner: str
-    test_name: str
-    run_id: str
-    status: str
-    start_time: datetime
     pub_time: datetime
-    end_time: datetime
-    version: Optional[str]
-    branch: Optional[str]
-    commit: Optional[str]
-
-    def __init__(

Review Comment:
   Think I fixed it, how does it look now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org