[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #283: JCRVLT-696: add logging for primary node type changes

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #283:
URL: https://github.com/apache/jackrabbit-filevault/pull/283#discussion_r1138928066


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -984,6 +984,7 @@ private void removeReferences(@NotNull Node node) throws ReferentialIntegrityExc
             if (importMode == ImportMode.REPLACE && !"rep:root".equals(primaryType) && wspFilter.includesProperty(PathUtil.append(node.getPath(), JcrConstants.JCR_PRIMARYTYPE))) {
                 if (!node.getPrimaryNodeType().getName().equals(primaryType)) {
                     vs.ensureCheckedOut();
+                    log.trace("Setting primary node type {} for {}", primaryType, node.getPath());

Review Comment:
   Maybe log both original and target primary node type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org