You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:23:26 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #2134: Respect Spark bundled log4j in extension modules
pan3793 opened a new pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
As Spark 3.1/3.2 still use log4j 1.2, we should respect Spark bundled log4j in extension modules.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825878054
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
Why are the test classname and test name sufficient but not clear? which part is unclear? can you explain more, it is quite hard to follow if the comment is too short.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825859918
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
are the test classname and test name insufficient ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825905092
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
Your concern is reasonable, personally I prefer to info level, I keep my opinion and will revert this change to make it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#issuecomment-1067522585
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825856162
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
To make the log clearly show failed in which module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825846805
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
why do we bring the maven build info log back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825856162
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
To make the log clearly show failure occurs in which module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825870764
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
sufficient but not clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825883204
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
> To make the log clearly show failure occurs in which module
You actually clearly get the module name `kyuubi-server_2.12`, class name and test name very easily.
```scala
AllKyuubiConfiguration:
- Check all kyuubi configs *** FAILED ***
java.lang.AssertionError: assertion failed: /home/runner/work/incubator-kyuubi/incubator-kyuubi/docs/deployment/settings.md out of date, please update doc with KYUUBI_UPDATE=1 build/mvn clean install -Pflink-provided,spark-provided -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
at scala.Predef$.assert(Predef.scala:223)
at org.apache.kyuubi.TestUtils$.verifyOutput(TestUtils.scala:57)
at org.apache.kyuubi.config.AllKyuubiConfiguration.$anonfun$new$1(AllKyuubiConfiguration.scala:264)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
at org.scalatest.Transformer.apply(Transformer.scala:22)
at org.scalatest.Transformer.apply(Transformer.scala:20)
at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
...
KyuubiOperationEnginePoolSuite:
- ensure app name contains engine-pool when engine pool is enabled.
- ensure the sub-domain doesn't work with the CONNECTION share level.
HudiOperationSuite:
Run completed in 14 minutes, 38 seconds.
Total number of tests run: 277
Suites: completed 44, aborted 0
Tests: succeeded 274, failed 3, canceled 0, ignored 2, pending 0
*** 3 TESTS FAILED ***
Error: Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.2:test (test) on project kyuubi-server_2.12: There are test failures -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.2:test (test) on project kyuubi-server_2.12: There are test failures
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#issuecomment-1066676496
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2134](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4792226) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/da22498a4f1015f9c4bdf28b40fa6d0a6ffd952c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da22498) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4792226 differs from pull request most recent head ba72d84. Consider uploading reports for the commit ba72d84 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2134 +/- ##
============================================
- Coverage 61.18% 61.15% -0.04%
Complexity 109 109
============================================
Files 318 318
Lines 15461 15461
Branches 1990 1990
============================================
- Hits 9460 9455 -5
- Misses 5194 5197 +3
- Partials 807 809 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [da22498...ba72d84](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#issuecomment-1070366056
Cherry picked this patch to branch-1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#issuecomment-1066676496
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2134](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4792226) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/da22498a4f1015f9c4bdf28b40fa6d0a6ffd952c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da22498) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4792226 differs from pull request most recent head 39f12c9. Consider uploading reports for the commit 39f12c9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2134 +/- ##
============================================
- Coverage 61.18% 61.15% -0.04%
Complexity 109 109
============================================
Files 318 318
Lines 15461 15461
Branches 1990 1990
============================================
- Hits 9460 9455 -5
- Misses 5194 5197 +3
- Partials 807 809 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [da22498...39f12c9](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825894921
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
> And I don't think the maven info level log is too noisy,
I almost review every single Pull request both on my laptop and on my phones, and can hardly put up with any more logs for a piece of quick advice for contributors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#issuecomment-1066676496
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2134](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4792226) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/da22498a4f1015f9c4bdf28b40fa6d0a6ffd952c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da22498) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4792226 differs from pull request most recent head 7429503. Consider uploading reports for the commit 7429503 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2134 +/- ##
============================================
- Coverage 61.18% 61.15% -0.04%
Complexity 109 109
============================================
Files 318 318
Lines 15461 15461
Branches 1990 1990
============================================
- Hits 9460 9455 -5
- Misses 5194 5197 +3
- Partials 807 809 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [da22498...7429503](https://codecov.io/gh/apache/incubator-kyuubi/pull/2134?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825883513
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
I can not remember which module the suite belong to for all classes, for `InsertShuffleNodeBeforeJoinSuite`, I can not know it belongs to `kyuubi-extension-spark-common` or `kyuubi-extension-spark-3-1` before searching codebase. And I don't think the maven info level log is too noisy, but gives much familiar information as run test in local in normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2134: Respect Spark bundled log4j in extension modules
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #2134:
URL: https://github.com/apache/incubator-kyuubi/pull/2134#discussion_r825888915
##########
File path: .github/workflows/master.yml
##########
@@ -73,7 +73,6 @@ jobs:
-Drat.skip=true
-Dscalastyle.skip=true
-Dspotless.check.skip
- -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
https://github.com/apache/spark/blob/master/.github/workflows/build_and_test.yml#L624 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org