[GitHub] mrutkows commented on issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location

[GitBox <gi...@apache.org>]

mrutkows commented on issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1016#issuecomment-442942954
 
 
   @pritidesai Believe that both CLI and wskdeploy SHOULD use the same lib., the REST CLI should ideally be agnostic of where (OS/platform) it invoked from if it needs to still have some odd way of providing defaults (not injected by tool using it) then it should also use same lib as an import (edited)
   
   I would think that the design should be that any IDE or app using REST directly should instantiate the go-client (or any client) with the values it needs for the target provider in general
   that is just good OO design...
   
   IMO, am 99% sure at least wskdeploy should use the same method CLI is using for consistency at least at our “layer” of tooling… and wskdeploy likely should adopt the ENV_ variable as well
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services