You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/02/03 22:55:44 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
zeroshade opened a new pull request, #34039:
URL: https://github.com/apache/arrow/pull/34039
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Yes, by integration testing.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1419161212
Also, it seems we need to use equals-ignoring-metadata for schemas (in all of C++/Go/Java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1419303556
@lidavidm I'm more confused honestly, that metadata looks identical to me... so I'm curious why it's tracking as failing the comparison....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1416502891
:warning: GitHub issue #33935 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1419414061
@lidavidm I figured out the issue, I had the metadata at Schema level, but the C++/java impls have the metadata at the column level. Latest change should fix it, hopefully this one should pass now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1419709273
@lidavidm the two spaces of indentation was supposed to indicate it was metadata for the field, schema level metadata would print out lined up with the top (no indentation) and column-level metadata prints out lined up with the column printout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1420452567
Benchmark runs are scheduled for baseline = 9b4c97242b1964ad42125c23d130ca44652da683 and contender = 2b661bad06bdb31eb54e1abadf396e95466637ca. 2b661bad06bdb31eb54e1abadf396e95466637ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/16bc0a192df043bb9333a87e547bbef7...7dce38208957469d82d3900fefd83896/)
[Finished :arrow_down:0.83% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cf3d02379b734eadb084bdb6d6dcac26...e259efc66c5a42c08417b799dd69733c/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2d104ca44fbe4f8a876a85065ab13452...003712cda92b4a67b9ef2e1e7e64a30f/)
[Finished :arrow_down:0.19% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/128fd73ccda44e558975d43f9bb9387e...6300d1d633994c388fb3c41cacc97a99/)
Buildkite builds:
[Finished] [`2b661bad` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2336)
[Finished] [`2b661bad` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2364)
[Finished] [`2b661bad` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2334)
[Finished] [`2b661bad` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2355)
[Finished] [`9b4c9724` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2335)
[Finished] [`9b4c9724` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2363)
[Finished] [`9b4c9724` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2333)
[Finished] [`9b4c9724` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2354)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1416502872
* Closes: #33935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #34039:
URL: https://github.com/apache/arrow/pull/34039#discussion_r1097885122
##########
go/arrow/internal/flight_integration/scenario.go:
##########
@@ -526,17 +526,17 @@ func (m *middlewareScenarioTester) GetFlightInfo(ctx context.Context, desc *flig
}, nil
}
-var (
- // Schema to be returned for mocking the statement/prepared statement
- // results. Must be the same across all languages
- QuerySchema = arrow.NewSchema([]arrow.Field{{
- Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
- Metadata: flightsql.NewColumnMetadataBuilder().
- TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
- TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
- CatalogName("catalog_test").Precision(100).Metadata(),
- }}, nil)
-)
+// var (
+// // Schema to be returned for mocking the statement/prepared statement
+// // results. Must be the same across all languages
+// QuerySchema = arrow.NewSchema([]arrow.Field{{
+// Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
+// Metadata: flightsql.NewColumnMetadataBuilder().
+// TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
+// TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
+// CatalogName("catalog_test").Precision(100).Metadata(),
+// }}, nil)
+// )
Review Comment:
i've removed it :) it was unncessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #34039:
URL: https://github.com/apache/arrow/pull/34039#issuecomment-1419319107
That's another question; I assume something differs in something that isn't being printed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #34039:
URL: https://github.com/apache/arrow/pull/34039#discussion_r1097663685
##########
go/arrow/internal/flight_integration/scenario.go:
##########
@@ -526,17 +526,17 @@ func (m *middlewareScenarioTester) GetFlightInfo(ctx context.Context, desc *flig
}, nil
}
-var (
- // Schema to be returned for mocking the statement/prepared statement
- // results. Must be the same across all languages
- QuerySchema = arrow.NewSchema([]arrow.Field{{
- Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
- Metadata: flightsql.NewColumnMetadataBuilder().
- TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
- TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
- CatalogName("catalog_test").Precision(100).Metadata(),
- }}, nil)
-)
+// var (
+// // Schema to be returned for mocking the statement/prepared statement
+// // results. Must be the same across all languages
+// QuerySchema = arrow.NewSchema([]arrow.Field{{
+// Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
+// Metadata: flightsql.NewColumnMetadataBuilder().
+// TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
+// TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
+// CatalogName("catalog_test").Precision(100).Metadata(),
+// }}, nil)
+// )
Review Comment:
Did you mean to comment this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #34039:
URL: https://github.com/apache/arrow/pull/34039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org