You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Dev-iL (via GitHub)" <gi...@apache.org> on 2026/03/01 15:14:41 UTC
[PR] Include a mypy stage in the main AGENTS' pre-push instructions [airflow]
Dev-iL opened a new pull request, #62675:
URL: https://github.com/apache/airflow/pull/62675
Also fix `--ref-from` -> `--from-ref`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include a mypy stage in the main AGENTS' pre-push instructions [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on PR #62675:
URL: https://github.com/apache/airflow/pull/62675#issuecomment-3980333666
LGTM @ extra commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include a mypy stage in the main AGENTS' pre-push instructions [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #62675:
URL: https://github.com/apache/airflow/pull/62675#discussion_r2869238221
##########
AGENTS.md:
##########
@@ -110,7 +110,7 @@ code review checklist in [`.github/instructions/code-review.instructions.md`](.g
API correctness, and AI-generated code signals. Fix any violations before pushing.
3. Confirm the code follows the project's coding standards and architecture boundaries
described in this file.
-4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+4. Run static checks (`prek run --from-ref <target_branch> --stage manual`) and fix any failures.
5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
6. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
Review Comment:
We should run both.
##########
AGENTS.md:
##########
@@ -110,7 +110,7 @@ code review checklist in [`.github/instructions/code-review.instructions.md`](.g
API correctness, and AI-generated code signals. Fix any violations before pushing.
3. Confirm the code follows the project's coding standards and architecture boundaries
described in this file.
-4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+4. Run static checks (`prek run --from-ref <target_branch> --stage manual`) and fix any failures.
5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
6. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
Review Comment:
```suggestion
4. Run regular static checks (`prek run --from-ref <target_branch>`) and fix any failures.
5. Run mypy checks (`prek run --from-ref <target_branch> --stage manual`) and fix any failures.
6. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
7. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include a mypy stage in the main AGENTS' pre-push instructions [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #62675:
URL: https://github.com/apache/airflow/pull/62675#discussion_r2869237592
##########
AGENTS.md:
##########
@@ -110,7 +110,7 @@ code review checklist in [`.github/instructions/code-review.instructions.md`](.g
API correctness, and AI-generated code signals. Fix any violations before pushing.
3. Confirm the code follows the project's coding standards and architecture boundaries
described in this file.
-4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+4. Run static checks (`prek run --from-ref <target_branch> --stage manual`) and fix any failures.
5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
6. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
Review Comment:
```suggestion
4. Run static checks (`prek run --from-ref <target_branch>`) and fix any failures.
5. Run mypy checks (`prek run --from-ref <target_branch> --stage manual`) and fix any failures.
6. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
7. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix prek arg (`--ref-from` -> `--from-ref`) in AGENTS.md [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #62675:
URL: https://github.com/apache/airflow/pull/62675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org